ci : Check run event for Kernel checker #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of QLI 2.0 Kernel CI/CD below should be flow : 1. Dev raises PR 2. Kernel checker is triggered 3. If kernel checker is passed, and maintainer approves PR then, Kernel CI/CD i.e sync, build test should trigger 4. If kernel checker fails, developer should fix the issue and repush the PR which will trigger kernel checker again To achieve this, post a check run event for kernel checker in pass case for QLI 2.0 branch. Based on check run event and approvals Kernel CI/CD will be triggered from Coral Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
Collaborator
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
How to give override for checker error if it will not be fixed ?
|
|
||
|
|
||
| check_run: | ||
| if: inputs.ref == 'qcom-6.18.y' |
Contributor
There was a problem hiding this comment.
can we use some config to handle this? If a new branch comes then again we need to add a condition here
In case the failure from Kernel checker can't be fixed, maintainer should have some way to override this, so that CI/CD can be triggered. Introdue a workflow, which can be triggered manually by maintainer with PR number, repo name and reason for override. This will generate a check_run event irrespective of the checker results. Maintainer can trigger override workflow either by UI by going to link : https://github.com/qualcomm-linux/kernel-config/actions Or by CLI with below : curl -X POST \ -H "Accept: application/vnd.github+json" \ -H "Authorization: Bearer <PAT>" \ -H "X-GitHub-Api-Version: 2022-11-28" \ https://api.github.com/repos/qualcomm-linux/kernel-config/actions/workflows/checker_override.yml/dispatches \ -d '{ "ref": "main", "inputs": { "pr_number": "<PR number>", "repo": "<repository > e.g qualcomm-linux/kernel", "reason": "<Reason for override>" } }' Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
Contributor
Author
Added a new workflow to help override. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of QLI 2.0 Kernel CI/CD below should be flow :
To achieve this, post a check run event for kernel checker in pass case for QLI 2.0 branch.
Based on check run event and approvals Kernel CI/CD will be triggered from Coral
Also introduce a workflow which will help override the kernel-checker in case of False positive