Enhance FIT image packaging: helper invocation, executable permissions, artifact rename, sector size configurability, and prerequisite installation

[bjordiscollaku]

This PR introduces multiple improvements to the FIT image packaging mechanism:

• Script header and argument fixes

  • Updated header to accurately reflect supported arguments.
  • Changed --dtb to --metadata for clarity.
  • Fixed typo: --kob → --kobj.
  • Added default paths in the options section for better usability.

• Helper script invocation improvements

  • Use absolute path for generate_boot_bins.sh based on the caller script’s directory.
  • Removed dependency on PATH to ensure consistent execution across environments.

• Executable permissions

  • Set executable bits for build scripts:
    • chmod +x kmake-image/make_fitimage.sh
    • chmod +x kmake-image/generate_boot_bins.sh

• Artifact naming

  • Renamed final packaged image from fit_dtb.bin to dtb.bin for consistency with downstream consumers and flashing tools.

• Sector size configurability

  • Added global --sector-size <bytes> option to generate_boot_bins.sh (default: 512).
    • Applies to all commands (dtb, bin, efi) in the invocation.
    • Overrides mkfs.vfat logical sector size when provided.
  • Added --sector-size <bytes> argument to make_fitimage.sh (default: 512).
    • Forwarded to generate_boot_bins.sh for FAT image creation.
  • Preserves existing behavior when not specified.

• Prerequisite installation

  • Added a conditional apt-get install step in make_fitimage.sh for required tools:
    • device-tree-compiler (provides dtc)
    • u-boot-tools (provides mkimage)
  • Runs only if apt-get is available and script executes as root.
  • Ensures environment readiness in CI and containerized builds.

---

Rationale

• Previous header inaccuracies could mislead users, and reliance on PATH for helper script invocation caused failures when executed from different directories.
• Missing executable bits prevented direct invocation of scripts.
• Renaming the final artifact improves clarity and aligns with naming conventions used by flashing tools.
• Configurable sector size enables compatibility with platforms requiring non-standard FAT layouts (e.g., 4096-byte sectors).
• Automatic installation of prerequisites improves robustness and reduces manual setup steps in CI environments.

---

Impact

• Breaking change: Any scripts or pipelines referencing fit_dtb.bin must be updated to dtb.bin.
• Eliminates "command not found" errors for helper script and required tools.
• Improves documentation accuracy and build reliability.
• Enables building FAT images with sector sizes other than 512 when required.

---

Usage Examples

Default sector size (512 bytes):

# FIT image packaging with explicit kernel build artifacts path
./make_fitimage.sh --metadata <path-to>/qcom-dtb-metadata/qcom-metadata.dts \
                   --its <path-to>/qcom-dtb-metadata/qcom-fitimage.its \
                   --kobj <path-to>/qcom-next/ \
                   --output dtb.bin

Custom sector size (4096 bytes):

# FIT image packaging with explicit kernel build artifacts path
./make_fitimage.sh --sector-size 4096 \
                   --metadata <path-to>/qcom-dtb-metadata/qcom-metadata.dts \
                   --its <path-to>/qcom-dtb-metadata/qcom-fitimage.its \
                   --kobj <path-to>/qcom-next/ \
                   --output dtb.bin

[Komal-Bajaj]

The Dockerfile already installs u-boot-tools; you could also include device-tree-compiler there.

[bjordiscollaku]

Both device-tree-compiler AND u-boot-tools are mandatory for the tool to execute, so until BOTH are included in Dockerfile definition, it's a must to have the tool install those as pre-req.

At the same time, there is no harm in having those there, taking in consideration support for local developer workflows independent of docker usage?