recipes-connectivity: wpa-supplicant: enable 802.11be, MBO, OWE #1140
Conversation
miaoqing-quic
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
|
I think, we have been though this. Was this attempted to be enabled in OE-core? Not to mention that commit message doesn't follow established practice. Please work with @sbanerjee-quic in order to write guidelines in a way that will be seen by you and by your colleagues. |
| sed -i -e 's/^#\(CONFIG_IEEE80211BE=y\)/\1/' \ | ||
| -e 's/^#\(CONFIG_MBO=y\)/\1/' \ | ||
| -e 's/^#\(CONFIG_OWE=y\)/\1/' wpa_supplicant/.config | ||
| } |
There was a problem hiding this comment.
This should go to oe-core directly.
There was a problem hiding this comment.
https://patchwork.yoctoproject.org/project/oe-core/patch/20250718030452.3459203-1-miaoqing.pan@oss.qualcomm.com/ has been pending for a long time.
There was a problem hiding this comment.
For such relatively trivial patches, you can ask for the status if it hasn't had feedback and hasn't been applied yet after 2 weeks.
There was a problem hiding this comment.
Strange, the message is visible on lore, but I don't see it in my lei mbox.
There was a problem hiding this comment.
For such relatively trivial patches, you can ask for the status if it hasn't had feedback and hasn't been applied yet after 2 weeks.
I saw lots of pending review patches, how to ask for the status ? Do you mean adding a comment ？
There was a problem hiding this comment.
Your recommendation is declined. Please follow Jouni's recommendation to stop using defconfigs and provide actual configs inside OE-Core. Inside those configs you can enable necessary features.
There was a problem hiding this comment.
0001-wpa-supplicant-restore-use-of-packaged-defconfig.patch
0002-wpa-supplicant-fix-sed-indentation.patch
0003-wpa-supplicant-enable-802.11be-support.patch
0004-wpa-supplicant-enable-OWE-support.patch
I uploade the patch series. Please help review it—I want to confirm whether it meets the requirements you mentioned. Thank you.
There was a problem hiding this comment.
Starting from patch1. Your commit message is not correct. You are not describing the issue you are trying to solve.
There was a problem hiding this comment.
Also, as Jouni wrote, we must change both wpa-supplicant and hostapd.
In future, don't post patches here. Post them to the OE-Core mailing list and CC my oss.q.c email.
There was a problem hiding this comment.
hostapd already uses packaged defconfig.
miaoqing-quic
force-pushed
the
wpa-supplicant-update
branch
from
eed6d8b to
3aed001
Compare
miaoqing-quic
force-pushed
the
wpa-supplicant-update
branch
from
3aed001 to
24b5ed2
Compare
wpa_supplicant has supported IEEE 802.11be (Wi-Fi 7) for over three years. With growing market demand for Wi-Fi 7, it is now an appropriate time to enable IEEE 802.11be Extremely High Throughput (EHT) support. This patch also enables the following features: Opportunistic Wireless Encryption (OWE) Multi Band Operation (MBO) Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
Test run workflowTest jobs for commit 3aed001
|
Test run workflowTest jobs for commit cabcf24
|
Test Results 14 files ±0 27 suites - 1 31m 57s ⏱️ + 2m 6s For more details on these failures, see this check. Results for commit cabcf24. ± Comparison against base commit dcc46e3. ♻️ This comment has been updated with latest results. |
Test run workflowTest jobs for commit cabcf24
|
6 participants
wpa_supplicant has supported IEEE 802.11be (Wi-Fi 7) for over three years. With growing market demand for Wi-Fi 7, it is now an appropriate time to enable IEEE 802.11be Extremely High Throughput (EHT) support.
This patch also enables the following features:
Opportunistic Wireless Encryption (OWE)
Multi Band Operation (MBO)