Skip to content

camera: add snapshot support for libcamerasrc and qtiqmmfsrc#434

Merged
smuppand merged 2 commits intoqualcomm-linux:mainfrom
nitinn22:feature/camera-tests-enhancements
May 6, 2026
Merged

camera: add snapshot support for libcamerasrc and qtiqmmfsrc#434
smuppand merged 2 commits intoqualcomm-linux:mainfrom
nitinn22:feature/camera-tests-enhancements

Conversation

@nitinn22
Copy link
Copy Markdown
Contributor

This PR enhances the camera validation suite with snapshot pipeline coverage.
Changes are split into two logical commits:

Camera tests: snapshot support for both libcamerasrc and qtiqmmfsrc
GStreamer helper: supporting snapshot pipeline construction for qtiqmmfsrc

@nitinn22 nitinn22 force-pushed the feature/camera-tests-enhancements branch 2 times, most recently from a2451f8 to a88d6ff Compare April 30, 2026 19:15
Copy link
Copy Markdown
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling the snapshot by default in the existing Camera_Tests flow. This changes the behavior of the current LAVA test from fakesink/preview/encode to fakesink/preview/encode/snapshot, adds jpegenc/multifilesink dependency coverage, and introduces a different still-capture validation path into the existing pre-merge test.

Suggested approach:

  • keep run.sh/lib_gstreamer.sh support for snapshot
  • keep Camera_Tests default as fakesink,preview,encode
  • add a separate Camera_Snapshot_Tests.yaml that runs the same run.sh with CAMERA_TEST_MODES=snapshot

This gives us snapshot coverage without disturbing the existing camera test flow.

Also please clean up the help text so the default test count remains 10/7, with snapshot adding 2 optional tests, and remove/log the currently unused gstRc variable in the snapshot functions.

@nitinn22
Copy link
Copy Markdown
Contributor Author

nitinn22 commented May 2, 2026

Hi @smuppand , snapshot is more of default test mode in camera which i added and it does not have to be separate optional entity, i added few functions to handle them which does not disturb existing implementation ideally, let me know if it does so. Its preferred to run all the 4 modes as mandatory and none are optional for camera imo, earlier we didn't have L0 for still snapshot only mode which we have now.

Comment thread Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests/run.sh Outdated
Comment thread Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests/run.sh Outdated
Comment thread Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests/run.sh Outdated
Comment thread Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests/run.sh Outdated
Comment thread Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests/run.sh Outdated
Comment thread Runner/suites/Multimedia/GSTreamer/Camera/Camera_Tests/run.sh Outdated
Comment thread Runner/utils/lib_gstreamer.sh Outdated
nitinn22 added 2 commits May 4, 2026 23:19
libcamerasrc

Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
@nitinn22 nitinn22 force-pushed the feature/camera-tests-enhancements branch from a88d6ff to 2da7a80 Compare May 4, 2026 17:57
@nitinn22
Copy link
Copy Markdown
Contributor Author

nitinn22 commented May 4, 2026

Addressed comments, dead code removed, size constant added and removed redundancy, error handling fixes from skip to fail for snapshot validations, preflight check added for snapshot test mode.

Copy link
Copy Markdown
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smuppand smuppand merged commit b0fc07e into qualcomm-linux:main May 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants