Skip to content

utils: validate overlay audio setup without chmod or restart#439

Merged
abbajaj806 merged 1 commit intoqualcomm-linux:mainfrom
smuppand:audio
May 5, 2026
Merged

utils: validate overlay audio setup without chmod or restart#439
abbajaj806 merged 1 commit intoqualcomm-linux:mainfrom
smuppand:audio

Conversation

@smuppand
Copy link
Copy Markdown
Contributor

@smuppand smuppand commented May 3, 2026

This PR updates the shared audio helper to align AudioPlayback and AudioRecord with the latest distro-side overlay audio fixes.

Fixes: #433

Why this PR is needed:
Issue #433 notes that meta-qcom-distro now handles the required dma_heap permission fix, so the audio tests no longer need to chmod /dev/dma_heap/system or restart PipeWire as part of the mandatory setup flow.

What this PR changes:

  • updates Runner/utils/audio_common.sh
  • changes setup_overlay_audio_environment() from a mutating setup helper into a non-mutating prerequisite validator
  • removes the mandatory chmod of /dev/dma_heap/system from the overlay setup path
  • removes the mandatory PipeWire restart from the overlay setup path
  • validates that /dev/dma_heap/system is already accessible
  • waits for PipeWire readiness without restarting it during setup

Comment thread Runner/utils/audio_common.sh
Replace the legacy overlay audio setup flow with non-mutating checks for dma_heap access and PipeWire readiness.

This aligns the audio tests with the distro-side permission fix and avoids hiding future regressions through chmod or mandatory service restart in the test setup.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Copy link
Copy Markdown
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbajaj806 abbajaj806 merged commit de0f7b9 into qualcomm-linux:main May 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audio test case steps update.

2 participants