audio: fix AudioRecord retry-path variable clobbering in LAVA#443
Merged
bhargav0610 merged 1 commit intoqualcomm-linux:mainfrom May 5, 2026
Merged
audio: fix AudioRecord retry-path variable clobbering in LAVA#443bhargav0610 merged 1 commit intoqualcomm-linux:mainfrom
bhargav0610 merged 1 commit intoqualcomm-linux:mainfrom
Conversation
Rename generic run.sh output path variables to record_out and update PipeWire helper functions to use safer local variable names. This avoids shell variable collisions in POSIX sh that could overwrite the recording output path and cause LAVA failures Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Contributor
Author
|
@bhargav0610 I tested on three different Lava setups and did not encounter the issue with the new patch. https://lava.infra.foundries.io/scheduler/job/198143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audio: fix AudioRecord filename clobbering on PipeWire retry path
This PR addresses #441.
AudioRecord can fail intermittently in LAVA after the PipeWire error path, where status text is accidentally reused as the recording output path and the script aborts with "File name too long" instead of producing a result file.
Fix this by renaming the run.sh output-path variable and by using safer variable names in PipeWire helper functions in audio_common.sh so sourced POSIX sh helpers do not clobber the caller state.
Fixes: #441