platforms: adds support for arduino unoq #46
Conversation
SuMere
commented
Oct 16, 2025
SuMere
commented
- adds partitions.conf default file for qualcomm base image
- adds partitions_user_16G.conf for arduino-specific images supporting userdata partition on 16GB emmc
SuMere
requested review from
lumag,
ndechesne,
sbanerjee-quic and
vkraleti
as code owners
| --partition --name=fsc --size=128KB --type-guid=57B90A16-22C9-E33B-8F5D-0E81686A68CB | ||
| --partition --name=efi --size=524288KB --type-guid=C12A7328-F81F-11D2-BA4B-00A0C93EC93B --filename=efi.bin | ||
| --partition --name=rootfs --size=10460284KB --type-guid=B921B045-1DF0-41C3-AF44-4C6F280D3FAE --filename=rootfs.img | ||
| --partition --name=userdata --size=2145728KB --type-guid=B921B045-1DF0-41C3-AF44-4C6F280D3FAE --filename=userdata.img No newline at end of file |
| @@ -0,0 +1,91 @@ | |||
| # Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved. | |||
There was a problem hiding this comment.
Just to note, this file be ignored. If it's something that you want to use in your builds, it is easier to spawn the 'qrb2210-unoq-16GiB' device.
There was a problem hiding this comment.
or create emmc-16GB and emmc-32GB folders, that looks 'nicer'
| --partition --name=fsc --size=128KB --type-guid=57B90A16-22C9-E33B-8F5D-0E81686A68CB | ||
| --partition --name=efi --size=524288KB --type-guid=C12A7328-F81F-11D2-BA4B-00A0C93EC93B --filename=efi.bin | ||
| --partition --name=rootfs --size=10460284KB --type-guid=B921B045-1DF0-41C3-AF44-4C6F280D3FAE --filename=rootfs.img | ||
|
|
There was a problem hiding this comment.
you need to squash your changes in the previous commit. we merge 'clean' history only.
There was a problem hiding this comment.
I'll mark the pr as draft, I'll be back in the office on monday
SuMere
force-pushed
the
feature/unoq-support
branch
from
38486dc to
939f9cc
Compare
SuMere
force-pushed
the
feature/unoq-support
branch
from
939f9cc to
f395e9d
Compare
- adds partitions.conf default file for qualcomm base image - adds partitions_user_16G.conf for arduino-specific images supporting userdata partition on 16GB emmc Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
SuMere
force-pushed
the
feature/unoq-support
branch
from
41fe251 to
609f63c
Compare
| --partition --name=fsg --size=2048KB --type-guid=638FF8E2-22C9-E33B-8F5D-0E81686A68CB | ||
| --partition --name=fsc --size=128KB --type-guid=57B90A16-22C9-E33B-8F5D-0E81686A68CB | ||
| --partition --name=efi --size=524288KB --type-guid=C12A7328-F81F-11D2-BA4B-00A0C93EC93B --filename=efi.bin | ||
| --partition --name=rootfs --size=10460284KB --type-guid=B921B045-1DF0-41C3-AF44-4C6F280D3FAE --filename=rootfs.img |
There was a problem hiding this comment.
what is the purpose of this conf file? the other one seems to be for the UnoQ with 16GB of eMMC. Is this one supposed to be for 32GB UnoQ?
Why is the userdata missing?
What do you expect to be different in the ptable between the 16GB and 32GB?
There was a problem hiding this comment.
This is the default partition table; it's a copy of the rb1 conf. It is intended for use when building a qcom image. Our flash recipe will navigate to the folder with the configuration for 16GB eMMC and use it.
When everything is tested on the 32GB emmc I will add a PR for it.
There was a problem hiding this comment.
ok, I would prefer to make it clear from the filename what it is, so :
- platforms/qrb2210-unoq/emmc/partitions.conf
- platforms/qrb2210-unoq/emmc-16GB/partitions.conf
could be:
- platforms/qrb2210-unoq/emmc-16GB/partitions.conf
- platforms/qrb2210-unoq/emmc-16GB-arduino/partitions.conf
and then we will add
- platforms/qrb2210-unoq/emmc-32GB/partitions.conf
- platforms/qrb2210-unoq/emmc-32GB-arduino/partitions.conf
the 'arduino' file is to be used with arduino images which have different ptable requirements than qcom reference imagses
There was a problem hiding this comment.
What is qcom reference image for the UnoQ? What is the expected difference between 'Qualcomm' and 'Arduino' images?
I'd prefer something like:
- platforms/qrb2210-unoq-16GB/emmc/
- platforms/qrb2210-unoq-32GB/emmc/
- etc.
There was a problem hiding this comment.
Arduino image has an additional partition mounted on "/home/arduino" folder in the ptool perspective. This is meant to allow users to build a qcom debian image without the extra Arduino features and flash it on the UnoQ.
In fact the platforms/qrb2210-unoq/emmc/partitions.conf file is the same as the rb1. Since the ptool conf file is dependent on the target board we would like to prevent the user from modifying the flash recipe when building the qcom reference image.
On the arduino image perspective, there is no problem for us to change the recipe and point to the correct conf file, hence the extra folder for our partition table.
There was a problem hiding this comment.
@lumag , it's really the Arduino image built/shipped by Arduino vs Qualcomm Linux images from QCOM (Debian/Yocto). So I don't think we should use 'unoq' in the filename to differenciate them.
|
We discussed this PR today; some of the key questions were:
It might be more practical for the Arduino specific scenario to leave outside of this repo so that there is a review step for new qcom-ptool changes from time to time, and Arduino can opt when to take the ptool changes, and adjust their files. A completely different approach from this PR would be to design a way to express the changes that Arduino wants to make to the partitions. For instance, expressing that the partitions should be the same as for RB1, but with a userdata partition added. It could be in ptool or around ptool, for instance a script generating or post-processing partitions.conf files, or an include mechanism. |
The same question will follow for other targets we might add via 3rdparty, and I believe if we merge a partition table specific for the arduino image (and not the board), then we should support variants. Generic images (from other generic distros) will probably want to consume the generic partition file for the target, and not the one for the arduino image. |
5 participants
