[qcom-next] Improve serial number detection using SMEM interface#52
Closed
balajiselvanathan wants to merge 1 commit intoqualcomm-linux:qcom-nextfrom
Closed
[qcom-next] Improve serial number detection using SMEM interface#52balajiselvanathan wants to merge 1 commit intoqualcomm-linux:qcom-nextfrom
balajiselvanathan wants to merge 1 commit intoqualcomm-linux:qcom-nextfrom
Conversation
b49020
reviewed
Apr 29, 2026
| * | ||
| * Return: 0 on success, negative error code on failure. | ||
| */ | ||
| int board_serial_num(u32 *serial_num_ptr); |
Member
There was a problem hiding this comment.
Where is this board_serial_num() implemented?
Author
There was a problem hiding this comment.
The definition of board_serial_num is part of [qcom-next] Add OF_LIVE device tree fixup infrastructure
#50
balajiselvanathan
force-pushed
the
fastboot_serial_num_qn1
branch
from
b59cbf6 to
e1a9eab
Compare
b49020
reviewed
May 4, 2026
Member
There was a problem hiding this comment.
Since board_serial_num() is statically defined, we don't this declaration any longer.
b49020
reviewed
May 4, 2026
| * | ||
| * Return: 0 on success, negative error code on failure. | ||
| */ | ||
| int board_serial_num(u32 *serial_num_ptr) |
Enhance serial number detection by prioritizing SMEM-based retrieval over bootargs parsing for better reliability and consistency across Qualcomm Snapdragon platforms. Add board_serial_num() function to retrieve serial number directly from SMEM using the socinfo interface. This provides access to the hardware-stored serial number in shared memory, eliminating the dependency on kernel command line parsing. This patch depends on the following patch [1], which adds the socinfo header file. [1] https://lore.kernel.org/all/20260106122134.2047864-3-aswin.murugan@oss.qualcomm.com/ Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
balajiselvanathan
force-pushed
the
fastboot_serial_num_qn1
branch
from
e1a9eab to
b2f009b
Compare
b49020
reviewed
May 4, 2026
| #include <sort.h> | ||
| #include <time.h> | ||
| #include <smem.h> | ||
| #include <soc/qcom/socinfo.h> |
Member
There was a problem hiding this comment.
This dependency header is not part of the qcom-next.
Author
There was a problem hiding this comment.
Yes, it is part of FIT DTB PR.
Member
|
@balajiselvanathan please validate serial number support already added by this PR: #56 |
Author
|
Hi Sumit, validated serial num working in fastboot using PR 56 and it is workinh. So, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance serial number detection by prioritizing SMEM-based retrieval over bootargs parsing for better reliability and consistency across Qualcomm Snapdragon platforms.
Add board_serial_num() function to retrieve serial number directly from SMEM using the socinfo interface. This provides access to the hardware-stored serial number in shared memory, eliminating the dependency on kernel command line parsing.
This patch depends on the following patch [1], which adds the socinfo header file.
[1] https://lore.kernel.org/all/20260106122134.2047864-3-aswin.murugan@oss.qualcomm.com/
Upstreamed Link: https://lore.kernel.org/u-boot/20260422-serial-v1-1-1f246885bd70@oss.qualcomm.com/