Update CHECK_LINK_STATES to account for ActBefore<LinkState> states #656
+101
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parth-07
force-pushed
the
NewLinkStates
branch
from
8d37c34 to
5d8a145
Compare
Contributor
|
is this a change that affects backwards compatibility ? |
partaror
force-pushed
the
NewLinkStates
branch
2 times, most recently
from
6cbc0ab to
422fd55
Compare
This commit updates CHECK_LINK_STATE functionality in the plugin framework to account for the ActBefore<LinkState> states. Until now, these link states did not exist in the linker and thus the plugin framework could not have checks for these states. Resolves qualcomm#655 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
partaror
force-pushed
the
NewLinkStates
branch
from
422fd55 to
b887887
Compare
Contributor
Author
No, this change does not affect backwards compatibility. If it does by any chance, then it is a bug in this change. |
Contributor
|
Can you pls verify this ? We dont want to break old plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates CHECK_LINK_STATE functionality in the plugin framework to account for the ActBefore states. Until now, these link states did not exist in the linker and thus the plugin framework could not have checks for these states.
Resolves #655