Improve reliability and tests for map_particle_hole_dm_to_one_pdm#1241
Open
mhucka wants to merge 3 commits intoquantumlib:mainfrom
Open
Improve reliability and tests for map_particle_hole_dm_to_one_pdm#1241mhucka wants to merge 3 commits intoquantumlib:mainfrom
mhucka wants to merge 3 commits intoquantumlib:mainfrom
Conversation
This change addresses a potential ZeroDivisionError in `map_particle_hole_dm_to_one_pdm` by raising a `ValueError` when the denominator is zero. It also adds a unit test to verify this behavior and ensure edge cases are handled correctly.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a check to prevent division by zero in the map_particle_hole_dm_to_one_pdm function and adds a corresponding unit test. Feedback suggests that instead of checking for a zero denominator, the code should validate that the number of particles does not exceed the number of basis functions, which is the underlying physical constraint.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses a potential ZeroDivisionError in
map_particle_hole_dm_to_one_pdmby raising aValueErrorwhen the denominator is zero. It also adds a unit test to verify this behavior and ensure edge cases are handled correctly.