Skip to content

Update some requirements to their latest versions#1309

Open
mhucka wants to merge 2 commits into
quantumlib:mainfrom
mhucka:update-requirements
Open

Update some requirements to their latest versions#1309
mhucka wants to merge 2 commits into
quantumlib:mainfrom
mhucka:update-requirements

Conversation

@mhucka
Copy link
Copy Markdown
Contributor

@mhucka mhucka commented May 16, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a wide range of dependencies across multiple environment files, including core packages like requests, mypy, and urllib3, as well as various type stubs. Feedback indicates that the version of types-requests is out of sync with the updated requests package and notes an incorrect dependency attribution for urllib3 in the metadata.

Comment on lines +242 to 243
types-requests==2.33.0.20260513
# via -r deps/mypy.txt
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version of types-requests (2.33.0) is out of sync with the updated requests version (2.34.2). Additionally, the dependency graph at line 260 incorrectly attributes the runtime package urllib3 to types-requests. These inconsistencies suggest that the selected version of types-requests is either outdated or contains incorrect metadata. Since this PR aims to update dependencies to their latest versions, please ensure that compatible and correctly-specified type stubs are used to avoid type-checking inaccuracies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant