Skip to content

Fix keyboard handling for Escape and Ctrl+Backspace in crumble#1037

Closed
Raycosine wants to merge 1 commit intoquantumlib:mainfrom
Raycosine:fix_keyboard_handlers_for_crumble
Closed

Fix keyboard handling for Escape and Ctrl+Backspace in crumble#1037
Raycosine wants to merge 1 commit intoquantumlib:mainfrom
Raycosine:fix_keyboard_handlers_for_crumble

Conversation

@Raycosine
Copy link

Both were not calling the methods, so the shortcuts didn’t work.

@google-cla
Copy link

google-cla bot commented Feb 3, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's embarrassing.

Thanks for catching it.

@Strilanc
Copy link
Collaborator

Strilanc commented Feb 4, 2026

Ah the error is just that the version built into stim's C++ source is desynced from the source. I can handle that.

@Strilanc
Copy link
Collaborator

Strilanc commented Feb 4, 2026

Can't push to your branch so I moved this to #1038 and will merge from there.

@Strilanc Strilanc closed this Feb 4, 2026
@Raycosine
Copy link
Author

Can't push to your branch so I moved this to #1038 and will merge from there.

Thanks a lot for handling the extra steps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants