This repository was archived by the owner on Dec 13, 2019. It is now read-only.
Add SW push/sync feature in dev mode#134
Open
sebastienroul wants to merge 4 commits intoquasarframework:devfrom
Open
Add SW push/sync feature in dev mode#134sebastienroul wants to merge 4 commits intoquasarframework:devfrom
sebastienroul wants to merge 4 commits intoquasarframework:devfrom
Conversation
Author
|
Here is the first part of the job to make PWA more easy to run in dev mode. As discuted on the Forum the previous way to play with SW in dev mode was "not efficient". Now I need help to make it run in build mode : I read the code and found in the webpack-config.js (line 353) a possible place to add this, but I'm not very sure how to inject the push and sync part at the end of the Then, when I will get the info for build injection, I'll be able to update the documentation. Best regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch and not themasterbranchfix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
The PR extends the Quasar-cli behaviour in Dev mode : It make it able to deliver the no-op service worker, but also a push and a sync part of code for managing this SW events by separating the source code.
The point is that the content of to files is append at the end of the generated no-op SW.