Add metastore_uri deduced from old variables example #93
Open
Add metastore_uri deduced from old variables example #93
Conversation
| You can use `config.metastore_uri` or `QW_METASTORE_URI` in `extraEnvFrom` instead (see | ||
| [documentation](https://quickwit.io/docs/configuration/metastore-config) for | ||
| more details). | ||
| more details). `metastore_uri` can be built with the old variables like this: `postgres://$(POSTGRES_USERNAME):$(POSTGRES_PASSWORD)@$(POSTGRES_HOST):$(POSTGRES_PORT)/$(POSTGRES_DATABASE)`. |
Collaborator
There was a problem hiding this comment.
Why refer to this as "old variables" ? Because they seems aren't mentioned somewhere anymore.
I'd replace "old" with "already defined environment variables on the pod" which can take other names btw, for example: postgres://$(PG_USER):$(PG_PASSWORD)@$(PG_HOST):$(PG_PORT)/$(PG_DATABASE).
It'll work regardless of the name if those environment variables are defined on the pod with extraEnv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.