fix(cross): bump libclang from 3.9 to 12 in cross images#6236
Open
fix(cross): bump libclang from 3.9 to 12 in cross images#6236
Conversation
Contributor
|
when trying locally, i get these errors: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The nightly Linux builds (
x86_64-unknown-linux-gnuandaarch64-unknown-linux-gnu) are failing with the following panic:Root cause
PR #5748 ("Add
--retriesparameter to CLI commands") updated OpenDAL as a side effect, which bumpedzstd-sysfrom2.0.13to2.0.15. Starting from2.0.15,zstd-sysgained abindgendependency, which in turn requiresclang-sys 1.8.1. That version callsclang_getTranslationUnitTargetInfo, a function only available inlibclang >= 5.0. Our cross images shiplibclang 3.9.x, which predates that API.Why clang-3.9 was used
clang-3.9was explicitly pinned in PR #2550 (Dec 2022) because the defaultclangversion was breaking the rocksdb build. However,rocksdbhas since been removed from the dependency tree entirely, so this constraint no longer applies.Fix
Bump
clang-3.9/libclang-3.9-devtoclang-12/libclang-12-devin both GNU cross images.clang-12is available in the Ubuntu 20.04 default apt repos (no extra LLVM apt source needed) and gives substantial headroom above thelibclang >= 5.0requirement.Remark
I am not super confortable skipping 10 versions. Should I?