Replace .gif in README with equivalent code#3021
Replace .gif in README with equivalent code#3021MichaelChirico wants to merge 12 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3021 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 128 128
Lines 7317 7317
=======================================
Hits 7261 7261
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bisaloo
left a comment
There was a problem hiding this comment.
FWIW, we could probably also go this way:
- save the content to lint to a tempfile
- include the content to lint in the README with the embed knitr engine:
```{embed, file=pathtofile} ``` - lint the file
This would ensure the displayed code and the linted code never go out of sync.
But it might be overengineering a little bit.
|
We do have https://github.com/r-lib/lintr/blob/bd016a02869dcec525d516bd63654f5b14cd4b01/inst/example/bad.R... my immediate worry is having the But I think we can use |
|
It's usually fair to assume the package has been installed beforehand when you render the README. But I also think we can always use the
|
Closes #2725. Because CRAN ships with one static .md file (that is not re-generated), the ~best solution I found would have involved a new step in the release process for generating the static file to ship.
Not worth it IMO when the proposal here works just as well. This also has the advantage of keeping the output correct to the day it's rendered.