Conversation
| uri <- paste0("file://", file) | ||
|
|
||
| lines <- ark_annotate_source(uri, paste_line(lines)) %||% lines | ||
| } |
There was a problem hiding this comment.
I'm somewhat inclined to want this whole thing to be in a tryCatch(), is it just me?
Like, what if normalizePath() fails?
What if we want to change ark_annotate_source() in some breaking way?
Since this feature is just about debugging, I'd hate for some kind of issue there to mean I can't load my package. That would be extremely frustrating as a devtools::load_all() user.
There was a problem hiding this comment.
and silently ignore errors? Or warn? hmm I don't know about either.
Basically we've exported ark_annotate_source from Ark and treat it like any other dependency.
If there is a problem and you can't debug anymore, it's frustrating for users too.
There was a problem hiding this comment.
A warning feels like the most useful compromise:
- you get to learn something has gone very wrong with annotations
- you still get to use your package, because nothing is actually wrong with it
There was a problem hiding this comment.
Because this function is called once per source file, this throws a ton of warnings when the annotation fails systematically, but this doesn't prevent pkgload from loading the package:
2 participants
No description provided.