Add vector methods for numbers in standalone-types-check.R (Fixes #1714)#1827
Open
khusmann wants to merge 2 commits intor-lib:mainfrom
Open
Add vector methods for numbers in standalone-types-check.R (Fixes #1714)#1827khusmann wants to merge 2 commits intor-lib:mainfrom
standalone-types-check.R (Fixes #1714)#1827khusmann wants to merge 2 commits intor-lib:mainfrom
Conversation
khusmann
force-pushed
the
add-numeric-checks
branch
from
ec1d314 to
3fc0cc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
check_number_decimal()tocheck_number()(at @lionel- 's suggestion)check_numeric()andcheck_numeric_whole(), vectorized versions ofcheck_number()andcheck_number_whole()Notes: The
allow_naandallow_nulllogic is getting pretty repetitive (and error handling is not standardized). Let me know if you'd like me to submit another PR to abstract this across thecheck_*()functions. It's not trivial because of the differences across types, but I think I see a nice way to go about this.