Conversation
gaborcsardi
left a comment
There was a problem hiding this comment.
Makes sense. AFAICT this does not solve one of the original issues (#931) because there the methods are added with $set() dynamically in a loop. OTOH that issue is probably solved best with dynamically generating the documentation as well, using `r ...`.
I am a bit worried about the edge cases, e.g. what if people put @R6method inside the R6 class, right before the method?
|
I think if you're dynamically generating the methods, you could still dynamically generate the roxygen comments, either by writing to a file or (maybe) with I probably won't merge this PR because I've decided it makes sense to tackle a bigger refactoring first: I want to add an intermediate layer of |
|
Superseded by #1824 |
object$set()so you can document dynamic method generation. Fixes Documentation for R6 methods added dynamically by "$set()" #931@R6methodtag as a generic way of documenting any R6 method. Fixes Document R6 methods created on $new()/$initialize() #991.