Open
Conversation
Fix issues like "OLLAMA_URL" setting not working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi developer.
The problem:
Setting the
OLLAMA_URLother than thehttp://localhost:11434value in.envfile, or setting upDEEPSEEK_OCR_OLLAMA_URLin environment variables does not come into effect.Example to reproduce:
export DEEPSEEK_OCR_OLLAMA_URL=http://192.168.5.8:11434 deepseek-ocr infowill get
I examined the source with the help of copilot, and notes that
ollama_urlargument ofModelManager.__init__does not seem to be filled properly when ModelManager is instantialized. So the solution could be:ModelManagerThis pull request choose the second way. This PR fixes issues like "OLLAMA_URL" setting not working.