Skip to content

refactor: nightly simplification sweep [automated] #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r3dbars merged 2 commits into from
May 2, 2026
Merged

refactor: nightly simplification sweep [automated] #635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02e912f
refactor: dedupe meeting recording stop snapshot
r3dbars May 1, 2026
1f84bf6
Document recording stop snapshot ordering
r3dbars May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 64 additions & 51 deletions Sources/Meeting/MeetingSessionController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,15 @@ final class MeetingSessionController: ObservableObject {
case failed(String)
}

private struct RecordingStopSnapshot {
let trigger: StartTrigger
let systemAudioStatus: SystemAudioStatus
let durationSeconds: TimeInterval
var durationMilliseconds: Int { Int(durationSeconds * 1000) }
let healthInfo: RecordingHealthInfo
let pipelineSnapshot: AudioPipelineDiagnosticsSnapshot
}

// MARK: - Published state (for meeting UI bindings)

/// High-level session state for the meeting UI.
Expand Down Expand Up @@ -498,86 +507,79 @@ final class MeetingSessionController: ObservableObject {
_ = audioInactivityDetector.stopRecording()
audioInactivityWarning = nil

let recordingTrigger = activeRecordingTrigger
let recordingSnapshot = makeRecordingStopSnapshot()

DiagnosticsTrail.record(
engine: "meeting",
event: "meeting_stop_requested",
message: "Meeting stop requested",
context: baseDiagnosticsContext(
extra: [
"trigger": recordingTrigger.rawValue,
"trigger": recordingSnapshot.trigger.rawValue,
"reason": reason.rawValue,
"duration_ms": "\(Int(recordingDuration * 1000))"
"duration_ms": "\(recordingSnapshot.durationMilliseconds)"
]
)
)

// Snapshot capture health BEFORE stop, since the system-audio backend
// can clean up buffer counters before file-close completion resumes.
let finalSystemAudioStatus = capture.systemAudioStatus
let finalRecordingDuration = recordingDuration
let healthInfo = capture.healthInfo(overrideSystemAudioStatus: finalSystemAudioStatus)
let pipelineSnapshot = capture.pipelineDiagnosticsSnapshot(overrideSystemAudioStatus: finalSystemAudioStatus)
let stopResult = await capture.stopAndAwaitFiles()
let files = (micURL: stopResult.micURL, systemURL: stopResult.systemURL)
let durationMs = Int(finalRecordingDuration * 1000)
activeRecordingTrigger = .unknown
state = .transcribing

DiagnosticsTrail.record(
level: finalSystemAudioStatus.isWarning ? .warning : .info,
level: recordingSnapshot.systemAudioStatus.isWarning ? .warning : .info,
engine: "meeting",
event: "meeting_recording_stopped",
message: "Meeting recording stopped",
context: baseDiagnosticsContext(
extra: [
"trigger": recordingTrigger.rawValue,
"trigger": recordingSnapshot.trigger.rawValue,
"reason": reason.rawValue,
"duration_ms": "\(durationMs)",
"duration_ms": "\(recordingSnapshot.durationMilliseconds)",
"mic_file_present": boolString(files.micURL != nil),
"system_file_present": boolString(files.systemURL != nil),
"stop_timed_out": boolString(stopResult.didTimeOut),
"capture_quality": healthInfo.captureQuality.rawValue,
"audio_gaps": "\(healthInfo.audioGaps)",
"device_switches": "\(healthInfo.deviceSwitches)"
"capture_quality": recordingSnapshot.healthInfo.captureQuality.rawValue,
"audio_gaps": "\(recordingSnapshot.healthInfo.audioGaps)",
"device_switches": "\(recordingSnapshot.healthInfo.deviceSwitches)"
]
)
)
AnalyticsReporter.track(
"meeting_recording_stopped",
properties: meetingCaptureAnalyticsProperties(snapshot: pipelineSnapshot).merging(
properties: meetingCaptureAnalyticsProperties(snapshot: recordingSnapshot.pipelineSnapshot).merging(
[
"capture_quality": healthInfo.captureQuality.rawValue,
"duration_bucket": AnalyticsReporter.durationBucket(seconds: finalRecordingDuration),
"gap_count_bucket": AnalyticsReporter.countBucket(healthInfo.audioGaps),
"capture_quality": recordingSnapshot.healthInfo.captureQuality.rawValue,
"duration_bucket": AnalyticsReporter.durationBucket(seconds: recordingSnapshot.durationSeconds),
"gap_count_bucket": AnalyticsReporter.countBucket(recordingSnapshot.healthInfo.audioGaps),
"reason": reason.rawValue,
"route_change_count_bucket": AnalyticsReporter.countBucket(healthInfo.deviceSwitches),
"route_change_count_bucket": AnalyticsReporter.countBucket(recordingSnapshot.healthInfo.deviceSwitches),
"system_stream_present": boolString(files.systemURL != nil),
"stop_timed_out": boolString(stopResult.didTimeOut),
"trigger": recordingTrigger.rawValue,
"trigger": recordingSnapshot.trigger.rawValue,
],
uniquingKeysWith: { _, new in new }
)
)
AnalyticsReporter.track(
"meeting_capture_health_snapshot",
properties: meetingCaptureHealthSnapshotProperties(
snapshot: pipelineSnapshot,
healthInfo: healthInfo,
trigger: recordingTrigger.rawValue,
snapshot: recordingSnapshot.pipelineSnapshot,
healthInfo: recordingSnapshot.healthInfo,
trigger: recordingSnapshot.trigger.rawValue,
reason: reason.rawValue,
durationSeconds: finalRecordingDuration,
durationSeconds: recordingSnapshot.durationSeconds,
systemStreamPresent: files.systemURL != nil,
stopTimedOut: stopResult.didTimeOut
)
)
reportCaptureHealthIfNeeded(
snapshot: pipelineSnapshot,
healthInfo: healthInfo,
trigger: recordingTrigger,
snapshot: recordingSnapshot.pipelineSnapshot,
healthInfo: recordingSnapshot.healthInfo,
trigger: recordingSnapshot.trigger,
reason: reason,
durationSeconds: finalRecordingDuration,
durationSeconds: recordingSnapshot.durationSeconds,
files: files,
stopTimedOut: stopResult.didTimeOut
)
Expand Down Expand Up @@ -620,8 +622,8 @@ final class MeetingSessionController: ObservableObject {
let outcome = enqueueTranscriptionJob(
micURL: micURL,
systemURL: files.systemURL,
healthInfo: healthInfo,
startTrigger: recordingTrigger
healthInfo: recordingSnapshot.healthInfo,
startTrigger: recordingSnapshot.trigger
)

let queueDepth = queuedTranscriptionJobs.count
Expand All @@ -633,9 +635,9 @@ final class MeetingSessionController: ObservableObject {
: "Meeting queued behind an earlier transcription",
context: baseDiagnosticsContext(
extra: [
"trigger": recordingTrigger.rawValue,
"trigger": recordingSnapshot.trigger.rawValue,
"reason": reason.rawValue,
"duration_ms": "\(durationMs)",
"duration_ms": "\(recordingSnapshot.durationMilliseconds)",
"queue_depth": "\(queueDepth)"
]
)
Expand Down Expand Up @@ -688,22 +690,17 @@ final class MeetingSessionController: ObservableObject {
_ = audioInactivityDetector.stopRecording()
audioInactivityWarning = nil

let recordingTrigger = activeRecordingTrigger
let finalSystemAudioStatus = capture.systemAudioStatus
let finalRecordingDuration = recordingDuration
let durationMs = Int(finalRecordingDuration * 1000)
let healthInfo = capture.healthInfo(overrideSystemAudioStatus: finalSystemAudioStatus)
let pipelineSnapshot = capture.pipelineDiagnosticsSnapshot(overrideSystemAudioStatus: finalSystemAudioStatus)
let recordingSnapshot = makeRecordingStopSnapshot()

DiagnosticsTrail.record(
engine: "meeting",
event: "meeting_cancel_requested",
message: "Meeting cancellation requested",
context: baseDiagnosticsContext(
extra: [
"trigger": recordingTrigger.rawValue,
"trigger": recordingSnapshot.trigger.rawValue,
"reason": reason.rawValue,
"duration_ms": "\(durationMs)"
"duration_ms": "\(recordingSnapshot.durationMilliseconds)"
]
)
)
Expand All @@ -720,9 +717,9 @@ final class MeetingSessionController: ObservableObject {
message: "Meeting recording cancelled",
context: baseDiagnosticsContext(
extra: [
"trigger": recordingTrigger.rawValue,
"trigger": recordingSnapshot.trigger.rawValue,
"reason": reason.rawValue,
"duration_ms": "\(durationMs)",
"duration_ms": "\(recordingSnapshot.durationMilliseconds)",
"mic_file_present": boolString(files.micURL != nil),
"system_file_present": boolString(files.systemURL != nil),
"stop_timed_out": boolString(stopResult.didTimeOut)
Expand All @@ -731,25 +728,25 @@ final class MeetingSessionController: ObservableObject {
)
AnalyticsReporter.track(
"meeting_recording_cancelled",
properties: meetingCaptureAnalyticsProperties(snapshot: pipelineSnapshot).merging(
properties: meetingCaptureAnalyticsProperties(snapshot: recordingSnapshot.pipelineSnapshot).merging(
[
"duration_bucket": AnalyticsReporter.durationBucket(seconds: Double(durationMs) / 1000),
"duration_bucket": AnalyticsReporter.durationBucket(seconds: recordingSnapshot.durationSeconds),
"reason": reason.rawValue,
"stop_timed_out": boolString(stopResult.didTimeOut),
"system_stream_present": boolString(files.systemURL != nil),
"trigger": recordingTrigger.rawValue,
"trigger": recordingSnapshot.trigger.rawValue,
],
uniquingKeysWith: { _, new in new }
)
)
AnalyticsReporter.track(
"meeting_capture_health_snapshot",
properties: meetingCaptureHealthSnapshotProperties(
snapshot: pipelineSnapshot,
healthInfo: healthInfo,
trigger: recordingTrigger.rawValue,
snapshot: recordingSnapshot.pipelineSnapshot,
healthInfo: recordingSnapshot.healthInfo,
trigger: recordingSnapshot.trigger.rawValue,
reason: reason.rawValue,
durationSeconds: Double(durationMs) / 1000,
durationSeconds: recordingSnapshot.durationSeconds,
systemStreamPresent: files.systemURL != nil,
stopTimedOut: stopResult.didTimeOut
)
Expand Down Expand Up @@ -1586,6 +1583,22 @@ final class MeetingSessionController: ObservableObject {
}
}

/// Snapshot capture health before the stop call, since the system-audio
/// backend can clean up buffer counters before file-close completion resumes.
private func makeRecordingStopSnapshot() -> RecordingStopSnapshot {
let systemAudioStatus = capture.systemAudioStatus
let durationSeconds = recordingDuration
return RecordingStopSnapshot(
trigger: activeRecordingTrigger,
systemAudioStatus: systemAudioStatus,
durationSeconds: durationSeconds,
healthInfo: capture.healthInfo(overrideSystemAudioStatus: systemAudioStatus),
pipelineSnapshot: capture.pipelineDiagnosticsSnapshot(
overrideSystemAudioStatus: systemAudioStatus
)
)
}

private func baseDiagnosticsContext(extra: [String: String] = [:]) -> [String: String] {
var context: [String: String] = [
"session_state": state.diagnosticName,
Expand Down