refactor: nightly simplification sweep [automated]

[r3dbars]

Summary

Nightly automated /simplify sweep. Two follow-up cleanups in
Sources/UI/Settings/HomeView.swift after the recent
"refactor: simplify home activity rows" commit (680ae33):

• HomeHeroCard: extract @ViewBuilder var actionCards to remove
  the two byte-for-byte identical HomeActionChoiceCard pairs inside
  ViewThatFits (the HStack-wrapped and VStack-wrapped branches were
  pure copy-paste).
• HomeActivityTabsCard.activitySubtitle: collapse the two
  near-identical switch arms by deriving the noun from
  selectedTab.label.lowercased() and selecting canLoadMore once.

Net diff: -41 / +29 lines, no behavior change.

What was reviewed

Three parallel review agents (reuse, quality, efficiency) inspected
HomeView.swift. Other findings — parameter-bundle refactor of
HomeActivityTabsCard, groupByDay middle-branch trim, ForEach offset
identity, cross-file DateFormatter consolidation — were deliberately
skipped as marginal, defensive, or scoped beyond this file.

Test plan

• bash build.sh — succeeded, app launches
• bash run-tests.sh — 1118 / 1118 pass
• bash run-integration-smoke.sh — 2 / 2 pass
• swift test — 107 / 107 pass

🤖 Generated with Claude Code

[r3dbars]

PR Review — refactor: nightly simplification sweep [automated]

Verdict: APPROVE

Summary: This PR extracts a duplicated HomeActionChoiceCard pair into a shared @ViewBuilder property and collapses two near-identical activitySubtitle switch arms into a single derivation. Both changes are correct, idiomatic SwiftUI, and reduce 41 lines to 29 with no behavior change. Clean and straightforward.

Blockers (must fix before merge):

• None.

Should fix (strongly recommended):

• None.

Nits (take or leave):

1. selectedTab.label.lowercased() → selectedTab.rawValue (HomeView.swift:895): The enum's rawValue is already "dictations" / "meetings" (lowercase). Going through .label (a display string: "Dictations") and then .lowercased() round-trips through unnecessary computation and creates a fragile coupling — if label is ever localized or reformatted, the subtitle silently breaks. selectedTab.rawValue is the stable, direct source.

2. IIFE for canLoadMore (HomeView.swift:889-894): The immediately-invoked closure wrapping a two-case switch is a bit heavy for what it does. A ternary or a small computed property reads more naturally in Swift:

   let canLoadMore = selectedTab == .dictations ? canLoadMoreDictations : canLoadMoreMeetings

   Not wrong as-is, just slightly more ceremony than needed.

What looks good:

• The @ViewBuilder extraction for ViewThatFits is exactly the right pattern — it eliminates a pure copy-paste duplication while preserving ViewThatFits's independent branch measurement behavior.
• The activitySubtitle consolidation correctly derives the noun from the tab enum rather than hardcoding strings per case. Good direction even if the source (label vs rawValue) could be tightened.
• Test coverage is thorough: build, unit tests (1118), integration smoke (2), and package tests (107) all pass.

---

Generated by Claude Code