Skip to content

[nightly-regression] Lock runtime diagnostics context keys #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r3dbars merged 1 commit into from
May 10, 2026
Merged

[nightly-regression] Lock runtime diagnostics context keys #701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Tests/RuntimeDiagnosticsStoreTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,25 @@ func testRuntimeDiagnosticsStore() {
assertEqual(context["session_duration_bucket"], "1_4m", "context should bucket previous session duration")
assertEqual(context["session_kind"], "dictation", "context should keep coarse session kind")
assertEqual(context["session_stage"], "recording", "context should keep coarse session stage")
assertEqual(
Set(context.keys),
[
"app_version",
"build_version",
"heartbeat_age_bucket",
"last_event",
"os_major",
"session_active",
"session_duration_bucket",
"session_kind",
"session_stage",
],
"unclean shutdown context should stay limited to previous-session runtime keys"
)
assertNil(context["previous_clean_shutdown"], "unclean shutdown context should not include current-session-only clean state")
assertNil(context["launch_id"], "launch IDs should not leak into unclean shutdown context")
assertNil(context["started_at"], "raw start timestamps should not leak into unclean shutdown context")
assertNil(context["updated_at"], "raw heartbeat timestamps should not leak into unclean shutdown context")
}

runSuite("RuntimeDiagnosticsStore builds current Sentry runtime context") {
Expand Down