Skip to content

Don't set encryptor purpose when using default key #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
themichaelyang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't set encryptor purpose when using default key #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rack/session/cookie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def initialize(app, options = {})
secrets = [*(options[:secrets] || options[:secret])]

encryptor_opts = {
purpose: options[:key], serialize_json: options[:serialize_json]
purpose: options[:key] != RACK_SESSION ? options[:key] : nil, serialize_json: options[:serialize_json]
}

# For each secret, create an Encryptor. We have iterate this Array at
Expand Down
8 changes: 6 additions & 2 deletions test/spec_session_cookie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,15 +366,19 @@ def decode(str); @calls << :decode; JSON.parse(str); end
end

it 'rejects session cookie with different purpose' do
app = [incrementor, { secrets: @secrets }]
other_app = [incrementor, { secrets: @secrets, key: 'other' }]
app = [incrementor, { secrets: @secret }] # key defaults to 'rack.session'
other_app = [incrementor, { secrets: @secret, key: 'other' }]
explicit_default_app = [incrementor, { secrets: @secret, key: 'rack.session' }]

response = response_for(app: app)
response.body.must_equal ({"counter"=>1}.to_s)

response = response_for(app: app, cookie: response)
response.body.must_equal ({"counter"=>2}.to_s)

response = response_for(app: explicit_default_app, cookie: response)
response.body.must_equal ({"counter"=>3}.to_s)

response = response_for(app: other_app, cookie: response)
response.body.must_equal ({"counter"=>1}.to_s)
end
Expand Down