-
-
Notifications
You must be signed in to change notification settings - Fork 53
chore: add portalling and make ui updates #1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fddc3f2
787bda1
2cb392d
ed375a2
7c4c040
66a2a91
c5cbb73
13c1e2a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@radui/ui": patch | ||
| --- | ||
|
|
||
| Fix select and combobox popup behavior by improving portal rendering, restoring macOS-style reopen anchoring for `Select`, and tightening related UI polish in the sandbox and shared component styles. |
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,88 @@ | ||||||||||||
|
|
||||||||||||
| Each step represents a **specific UI intent**, not just a color. | ||||||||||||
|
|
||||||||||||
| --- | ||||||||||||
|
|
||||||||||||
| ## Core Principles | ||||||||||||
|
|
||||||||||||
| ### 1. Perceptual Consistency | ||||||||||||
| - Steps must feel evenly spaced to the human eye | ||||||||||||
| - Do NOT use linear interpolation blindly | ||||||||||||
| - Avoid muddy midtones or sudden jumps | ||||||||||||
|
|
||||||||||||
| Bad: | ||||||||||||
| - 400 → 500 barely changes | ||||||||||||
| - 700 → 800 jumps too much | ||||||||||||
|
|
||||||||||||
| Good: | ||||||||||||
| - Smooth, predictable progression | ||||||||||||
|
|
||||||||||||
| --- | ||||||||||||
|
|
||||||||||||
| ### 2. Intent-Based Design (VERY IMPORTANT) | ||||||||||||
|
|
||||||||||||
|
|
||||||||||||
| | Step | Token | Category | Usage Description | | ||||||||||||
| |------|------|---------------------------|------------------| | ||||||||||||
| | 1 | 50 | Backgrounds | App/page background, lowest visual weight | | ||||||||||||
| | 2 | 100 | Backgrounds | Subtle surfaces, section backgrounds | | ||||||||||||
| | 3 | 200 | Interactive components | Hover backgrounds, subtle interaction states | | ||||||||||||
| | 4 | 300 | Interactive components | Active/pressed states, stronger surface contrast | | ||||||||||||
| | 5 | 400 | Interactive components | Selected states, emphasized surfaces | | ||||||||||||
| | 6 | 500 | Borders & separators | Light borders, dividers | | ||||||||||||
| | 7 | 600 | Borders & separators | Default borders, stronger separators | | ||||||||||||
| | 8 | 700 | Solid colors | Disabled text/icons, muted UI elements | ||||||||||||
| | 9 | 800 | Solid colors | supporting content | ||||||||||||
| | 10 | 900 | Accessible text | Secondary text, high readability | | ||||||||||||
| | 11 | 1000 | Accessible text | Headings,Primary text, max contrast text (near black) | | ||||||||||||
| --- | ||||||||||||
|
Comment on lines
+37
to
+38
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a blank line after the table block. Line 38 should be separated from the table by a blank line to satisfy markdown table boundary rules. Proposed fix-| 11 | 1000 | Accessible text | Headings,Primary text, max contrast text (near black) |
----
+| 11 | 1000 | Accessible text | Headings, Primary text, max contrast text (near black) |
+
+---📝 Committable suggestion
Suggested change
🧰 Tools🪛 markdownlint-cli2 (0.22.0)[warning] 37-37: Tables should be surrounded by blank lines (MD058, blanks-around-tables) 🤖 Prompt for AI Agents |
||||||||||||
|
|
||||||||||||
| ### 3. No Pure Extremes | ||||||||||||
|
|
||||||||||||
| - ❌ No `#ffffff` | ||||||||||||
| - ❌ No `#000000` | ||||||||||||
|
|
||||||||||||
| Why? | ||||||||||||
| Pure colors feel harsh and break layering. | ||||||||||||
|
|
||||||||||||
| Instead: | ||||||||||||
| - 50 → neutral white — no hue tint (off-white, not `#ffffff`) | ||||||||||||
| - 1000 → neutral near-black — no hue tint (not `#000000`) | ||||||||||||
|
|
||||||||||||
| --- | ||||||||||||
|
|
||||||||||||
| ### 4. Neutral Only | ||||||||||||
|
|
||||||||||||
| - No hue tint (including blue/green/purple); chroma stays at zero | ||||||||||||
| - True grayscale only: neutral white through neutral near-black | ||||||||||||
|
|
||||||||||||
| If you want semantic colors, define them separately. | ||||||||||||
|
|
||||||||||||
| --- | ||||||||||||
|
|
||||||||||||
| ### 5. Accessibility First | ||||||||||||
|
|
||||||||||||
| - Text (900–1000) must meet **WCAG AA** | ||||||||||||
| - Borders (400–500) must be visible but not distracting | ||||||||||||
| - Avoid low contrast adjacent steps | ||||||||||||
|
|
||||||||||||
| --- | ||||||||||||
|
|
||||||||||||
| ## Reference Scale (Baseline) | ||||||||||||
|
|
||||||||||||
| This is the default Rad UI grayscale. | ||||||||||||
|
|
||||||||||||
| ```json | ||||||||||||
| { | ||||||||||||
| "50": "#fafafa", | ||||||||||||
| "100": "#f4f4f5", | ||||||||||||
| "200": "#e4e4e7", | ||||||||||||
| "300": "#d4d4d8", | ||||||||||||
| "400": "#a1a1aa", | ||||||||||||
| "500": "#71717a", | ||||||||||||
| "600": "#52525b", | ||||||||||||
| "700": "#3f3f46", | ||||||||||||
| "800": "#27272a", | ||||||||||||
| "900": "#18181b", | ||||||||||||
| "1000": "#0f0f11" | ||||||||||||
| } | ||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -308,4 +308,4 @@ | |
| "eslint": "$eslint" | ||
| } | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix malformed table rows (missing trailing pipe).
Line 34 and Line 35 are missing the closing
|, so markdown table rendering/linting can break.Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 34-34: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
[warning] 35-35: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
🤖 Prompt for AI Agents