Add --force flag to rad resource delete and rad app delete by willdavsmith · Pull Request #11625 · radius-project/radius

willdavsmith · 2026-04-10T17:51:19Z

Description

Add a --force option to both rad resource delete and rad app delete commands that allows users to delete resources stuck in non-terminal provisioning states (e.g., "Updating", "Accepted") which otherwise return a 409 Conflict.

Server-side: DefaultAsyncDelete reads a force=true query parameter and skips the provisioning state conflict check, while still validating ETags and running delete filters.

Client-side: A forceDeletePolicy pipeline policy injects force=true as a query parameter when the force option is set, avoiding changes to the auto-generated SDK.

CLI: Both commands accept --force, display a warning about potential orphaned external resources, and pass the flag through to the API.

Concurrency safety

When force-deleting a resource with an in-flight operation, the existing safety nets handle the race:

The async worker gracefully handles ErrNotFound when the resource is deleted out from under it
ETag optimistic concurrency prevents silent state corruption
Each operation has independent status tracking

The residual risk (orphaned external resources from a concurrent update) is the standard --force contract — the user acknowledges this via the warning message.

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #11147
Fixes: #3972

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

Add a --force option to both 'rad resource delete' and 'rad app delete' commands that allows users to delete resources stuck in non-terminal provisioning states (e.g., Updating, Accepted). Server-side: DefaultAsyncDelete reads a 'force' query parameter and skips the provisioning state conflict check when force=true, while still validating ETags and running delete filters. Client-side: A forceDeletePolicy pipeline policy injects force=true as a query parameter when the force option is set. CLI: Both commands accept --force, display a warning about potential orphaned external resources, and pass the flag through to the API.

Add a --force option to both 'rad resource delete' and 'rad app delete' commands that allows users to delete resources stuck in non-terminal provisioning states (e.g., Updating, Accepted). Server-side: DefaultAsyncDelete reads a 'force' query parameter and skips the provisioning state conflict check when force=true, while still validating ETags and running delete filters. Client-side: A forceDeletePolicy pipeline policy injects force=true as a query parameter when the force option is set. CLI: Both commands accept --force, display a warning about potential orphaned external resources, and pass the flag through to the API. Signed-off-by: willdavsmith <willdavsmith@gmail.com>

Copilot

Pull request overview

Adds a --force deletion capability across Radius CLI, client, and server to allow deleting resources stuck in non-terminal provisioning states (avoiding 409 Conflict), while still honoring ETag validation and delete filters.

Changes:

CLI: add --force to rad resource delete and rad app delete, including user-facing warnings.
CLI client: plumb a force boolean through delete APIs and inject force=true via an Azure SDK per-call pipeline policy (avoids modifying generated SDK signatures).
Server: DefaultAsyncDelete recognizes force=true and skips the non-terminal provisioning-state conflict check; tests extended accordingly.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/validation/shared.go	Updates helper to call `DeleteResource(..., false)` with new signature.
test/functional-portable/cli/noncloud/cli_test.go	Updates functional tests for new `DeleteResource(..., force)` signature.
pkg/cli/delete/delete.go	Passes `Force` through to `DeleteApplication(...)`.
pkg/cli/delete/delete_test.go	Updates mocks for new `DeleteApplication(..., force)` signature.
pkg/cli/cmd/resource/delete/delete.go	Adds `--force`, warning text, and passes force to management client.
pkg/cli/cmd/commonflags/flags.go	Introduces shared `AddForceFlag`.
pkg/cli/cmd/app/delete/delete.go	Adds `--force`, warning text, and passes force into delete progress flow.
pkg/cli/clients/mock_applicationsclient.go	Regenerates mocks for updated delete method signatures.
pkg/cli/clients/management.go	Adds `force` plumbing and `forceDeletePolicy` for query injection on generic deletes.
pkg/cli/clients/management_test.go	Updates tests for new signatures (no force-specific assertions added).
pkg/cli/clients/clients.go	Extends interfaces/options to include `Force`.
pkg/armrpc/frontend/defaultoperation/defaultasyncdelete.go	Implements `force=true` behavior in async delete.
pkg/armrpc/frontend/defaultoperation/defaultasyncdelete_test.go	Adds/extends tests for force-delete paths and filter behavior.

github-actions · 2026-04-10T18:04:01Z

Unit Tests

2 files ± 0 415 suites ±0 6m 33s ⏱️ -18s
4 882 tests +16 4 880 ✅ +16 2 💤 ±0 0 ❌ ±0
5 787 runs +18 5 785 ✅ +18 2 💤 ±0 0 ❌ ±0

Results for commit af5be38. ± Comparison against base commit ec789e8.

♻️ This comment has been updated with latest results.

- Fix DeleteApplication to also inject force=true when deleting the application resource itself (not just child resources) - Add Test_ForceDeletePolicy verifying the pipeline policy correctly injects the force=true query parameter

…to fix-409

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

codecov · 2026-04-10T22:17:14Z

Codecov Report

❌ Patch coverage is 89.61039% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.49%. Comparing base (ec789e8) to head (af5be38).

Files with missing lines	Patch %	Lines
pkg/cli/clients/management.go	95.74%	1 Missing and 1 partial ⚠️
pkg/cli/cmd/app/delete/delete.go	77.77%	1 Missing and 1 partial ⚠️
pkg/cli/cmd/commonflags/flags.go	0.00%	2 Missing ⚠️
pkg/cli/cmd/resource/delete/delete.go	81.81%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11625      +/-   ##
==========================================
+ Coverage   51.40%   51.49%   +0.08%     
==========================================
  Files         699      699              
  Lines       44036    44085      +49     
==========================================
+ Hits        22638    22700      +62     
+ Misses      19244    19225      -19     
- Partials     2154     2160       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Now that DeleteResource supports force=true, the retry-with-backoff loop for 409 Conflict errors in DeleteRPResourceSilent is unnecessary. Use force=true directly to handle resources stuck in non-terminal provisioning states during test cleanup.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

- Move force-delete warning before the confirmation prompt in both rad resource delete and rad app delete so users see the risk before confirming. - Add test case for force-delete with incorrect ETag to verify 412 Precondition Failed is returned.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Add tests covering the --force flag in rad resource delete and rad app delete to improve patch coverage for the force-delete code paths.

- Move force-delete warning outside the confirmation prompt block so it is shown even with --yes --force. - Update doc comments on createApplicationClient and getGenericClient to clarify that force policy injection only applies when no factory is configured.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

The policy was applying force=true to all requests including poller GETs. Now it only modifies DELETE requests and skips if force is already set.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

lakshmimsft · 2026-04-23T21:48:10Z


-	if err != nil {
-		return nil, err
+	clientOptions := *amc.ClientOptions


are these lines of code doing the same as ~ln1211-ln1220? should it be pulled out into a helper funciton?

Good catch — they were doing the same thing. Extracted into a withForceDeletePolicy helper in bb897a6 so both createApplicationClient and getGenericClient share the same logic for appending the per-call policy.

github-actions · 2026-04-30T14:57:52Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

radius-functional-tests · 2026-04-30T15:50:03Z

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details

Name	Value
Repository	radius-project/radius
Commit ref	`af5be38`
Unique ID	func4189e61582
Image tag	pr-func4189e61582

gotestsum 1.13.0
KinD: v0.29.0
Dapr: 1.14.4
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4189e61582
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4189e61582
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func4189e61582
controller test image location: ghcr.io/radius-project/dev/controller:pr-func4189e61582
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4189e61582
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

willdavsmith requested a review from a team as a code owner April 10, 2026 17:51

willdavsmith added the pr:standard label Apr 10, 2026

willdavsmith requested a review from a team as a code owner April 10, 2026 17:51

Copilot AI review requested due to automatic review settings April 10, 2026 17:51

willdavsmith added the pr:standard label Apr 10, 2026

willdavsmith requested a deployment to external-contributor-approval April 10, 2026 17:51 — with GitHub Actions Waiting

Copilot started reviewing on behalf of willdavsmith April 10, 2026 17:51 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread pkg/cli/clients/management.go

Comment thread pkg/cli/clients/management.go Outdated

willdavsmith added 2 commits April 10, 2026 14:55

Merge branch 'fix-409' of https://github.com/radius-project/radius in…

1413461

…to fix-409

willdavsmith requested a deployment to external-contributor-approval April 10, 2026 22:02 — with GitHub Actions Waiting

willdavsmith requested a review from Copilot April 10, 2026 22:02

Copilot started reviewing on behalf of willdavsmith April 10, 2026 22:03 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread pkg/cli/clients/management.go Outdated

Comment thread pkg/cli/clients/management.go Outdated

Comment thread pkg/cli/delete/delete.go

github-actions Bot mentioned this pull request Apr 11, 2026

Causinator 9000 CI Failure Digest — 2026-04-11 #11633

Open

willdavsmith requested a review from sylvainsf April 13, 2026 18:16

PR

025a69b

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

willdavsmith requested a review from Copilot April 13, 2026 21:15

Copilot started reviewing on behalf of willdavsmith April 13, 2026 21:15 View session

willdavsmith requested a deployment to external-contributor-approval April 13, 2026 21:15 — with GitHub Actions Waiting

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread test/validation/shared.go Outdated

willdavsmith requested a deployment to external-contributor-approval April 13, 2026 21:31 — with GitHub Actions Waiting

willdavsmith requested a review from Copilot April 13, 2026 21:36

Copilot started reviewing on behalf of willdavsmith April 13, 2026 21:36 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread pkg/cli/cmd/resource/delete/delete.go Outdated

Comment thread pkg/cli/cmd/app/delete/delete.go Outdated

Comment thread pkg/armrpc/frontend/defaultoperation/defaultasyncdelete_test.go

willdavsmith requested a deployment to external-contributor-approval April 13, 2026 21:53 — with GitHub Actions Waiting

willdavsmith requested a review from Copilot April 14, 2026 15:37

Copilot started reviewing on behalf of willdavsmith April 14, 2026 15:37 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread pkg/cli/cmd/resource/delete/delete.go Outdated

Comment thread pkg/cli/cmd/app/delete/delete.go Outdated

Comment thread pkg/cli/clients/management.go Outdated

Comment thread pkg/cli/clients/management.go

Add force=true test cases for CLI delete commands

eb2cbc3

Add tests covering the --force flag in rad resource delete and rad app delete to improve patch coverage for the force-delete code paths.

willdavsmith requested a deployment to external-contributor-approval April 14, 2026 15:50 — with GitHub Actions Waiting

willdavsmith requested a deployment to external-contributor-approval April 14, 2026 15:57 — with GitHub Actions Waiting

willdavsmith requested a review from Copilot April 14, 2026 16:03

Copilot started reviewing on behalf of willdavsmith April 14, 2026 16:05 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread pkg/cli/clients/management.go Outdated

Restrict forceDeletePolicy to DELETE requests only

00411de

The policy was applying force=true to all requests including poller GETs. Now it only modifies DELETE requests and skips if force is already set.

willdavsmith temporarily deployed to external-contributor-approval April 14, 2026 16:22 — with GitHub Actions Inactive

willdavsmith requested a review from Copilot April 14, 2026 16:31

Copilot started reviewing on behalf of willdavsmith April 14, 2026 16:32 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

nicolejms assigned willdavsmith Apr 21, 2026

lakshmimsft reviewed Apr 23, 2026

View reviewed changes

Extract withForceDeletePolicy helper to dedupe client option setup

bb897a6

willdavsmith requested a review from lakshmimsft April 30, 2026 15:43

Merge branch 'main' into fix-409

af5be38

Conversation

willdavsmith commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Concurrency safety

Type of change

Contributor checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

lakshmimsft Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

willdavsmith Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

radius-functional-tests Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Reviewers

Assignees

Labels

Projects

willdavsmith commented Apr 10, 2026 •

edited

Loading

github-actions Bot commented Apr 10, 2026 •

edited

Loading

codecov Bot commented Apr 10, 2026 •

edited

Loading

lakshmimsft Apr 23, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading

radius-functional-tests Bot commented Apr 30, 2026 •

edited

Loading