Fix button name submission when using the "disable-with" feature#16
Open
willbryant wants to merge 1 commit intorails:masterfrom
willbryant:17170810d0b62049c32524219d7fe576a11b1e5b
Open
Fix button name submission when using the "disable-with" feature#16willbryant wants to merge 1 commit intorails:masterfrom willbryant:17170810d0b62049c32524219d7fe576a11b1e5b
willbryant wants to merge 1 commit intorails:masterfrom
willbryant:17170810d0b62049c32524219d7fe576a11b1e5b
Conversation
…button's name and value need to be submitted as a hidden input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Rails 2.2 a fix was put in for the case when a button has disable-with set: the library needs to add a hidden form field with the same name and value as the button had, because disabled form elements aren't included in the serialized form contents.
This fix was lost in the prototype-rails extraction. This patch adds it back.
We've been using it for the last year and it merges cleanly to master still.