Skip to content

copy-artifacts: use shared rainix reusable + fix stale CLAUDE.md deps#225

Merged
thedavidmeister merged 5 commits into
mainfrom
2026-05-27-reusable-copy-artifacts
May 27, 2026
Merged

copy-artifacts: use shared rainix reusable + fix stale CLAUDE.md deps#225
thedavidmeister merged 5 commits into
mainfrom
2026-05-27-reusable-copy-artifacts

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

Replace the local copy-artifacts.yaml with a thin caller of rainix-copy-artifacts.yaml (rainlanguage/rainix#201) — centralizes build-and-assert-clean + the Cachix/GC-cap resilience. This repo's CopyArtifacts.sol doesn't use ffi; the reusable's --ffi is a no-op here. (The reusable also runs BuildPointers.sol when present — same plain forge script invocation as rainix-build-pointers, so it's consistent.)

Also fixes the stale CLAUDE.md "Git submodules" deps section — the repo is on Soldeer (dependencies/, no lib/).

🤖 Generated with Claude Code

Replace the local workflow with a thin caller of rainix-copy-artifacts.yaml
(rainix#201) — centralizes build-and-assert-clean + Cachix/GC-cap resilience.
This repos CopyArtifacts.sol does not use ffi; the reusables --ffi is a no-op
here.
The repo migrated to Soldeer (soldeer.lock, [dependencies] in foundry.toml,
libs=dependencies/, no .gitmodules/lib). Update the stale dependency docs.
@thedavidmeister thedavidmeister self-assigned this May 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Warning

Review limit reached

@thedavidmeister, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 16 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 58b63d7f-80ca-43bd-8919-786856231967

📥 Commits

Reviewing files that changed from the base of the PR and between dab95cc and 2b7d92a.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (43)
  • .envrc
  • .github/workflows/build-pointers.yaml
  • .github/workflows/copy-artifacts.yaml
  • .github/workflows/pr-assessment.yaml
  • .vscode/settings.json
  • CLAUDE.md
  • README.md
  • audit/2026-03-10-01/pass0/process.md
  • audit/2026-03-10-01/pass1/DecimalFloat.md
  • audit/2026-03-10-01/pass1/LibDecimalFloat.md
  • audit/2026-03-10-01/pass1/LibDecimalFloatDeploy.md
  • audit/2026-03-10-01/pass1/LibDecimalFloatImplementation.md
  • audit/2026-03-10-01/pass1/LibFormatDecimalFloat.md
  • audit/2026-03-10-01/pass1/LibLogTable.md
  • audit/2026-03-10-01/pass1/LibParseDecimalFloat.md
  • audit/2026-03-10-01/pass1/LogTablesPointers.md
  • audit/2026-03-10-01/pass1/errors.md
  • audit/2026-03-10-01/pass1/scripts.md
  • audit/2026-03-10-01/pass2/DecimalFloat.md
  • audit/2026-03-10-01/pass2/LibDecimalFloat.md
  • audit/2026-03-10-01/pass2/LibDecimalFloatImplementation.md
  • audit/2026-03-10-01/pass2/LibFormatDecimalFloat.md
  • audit/2026-03-10-01/pass2/errors_gen_deploy.md
  • audit/2026-03-10-01/pass2/parse_and_tables.md
  • audit/2026-03-10-01/pass3/DecimalFloat.md
  • audit/2026-03-10-01/pass3/LibDecimalFloat.md
  • audit/2026-03-10-01/pass3/impl_format_parse.md
  • audit/2026-03-10-01/pass3/misc.md
  • audit/2026-03-10-01/pass4/LibDecimalFloat.md
  • audit/2026-03-10-01/pass4/concrete_errors_deploy.md
  • audit/2026-03-10-01/pass4/impl_format_parse_table.md
  • audit/2026-03-10-01/pass5/LibDecimalFloat.md
  • audit/2026-03-10-01/pass5/LibDecimalFloatImplementation.md
  • audit/2026-03-10-01/pass5/concrete_errors_deploy.md
  • audit/2026-03-10-01/pass5/format_parse_table.md
  • audit/2026-03-10-01/triage.md
  • audit/2026-03-23-01/triage.md
  • package.json
  • scripts/build.js
  • slither.config.json
  • test_js/float.test.ts
  • test_js/tsconfig.json
  • tsconfig.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-27-reusable-copy-artifacts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

rainix#195 runs the pre-commit bundle in rs-static CI; this repo had
accumulated hook-dirt (denofmt on audit/*.md + README, prettier on test_js +
json, yamlfmt on pr-assessment, shellcheck .envrc shebang). Formatting + one
shellcheck directive only; no source/behaviour changes.
rainix-copy-artifacts (this repo's copy-artifacts.yaml caller) already runs
BuildPointers.sol via its hashFiles guard, so the standalone build-pointers
workflow is redundant. One artifact-check workflow instead of two.
@thedavidmeister thedavidmeister merged commit 85fb814 into main May 27, 2026
9 checks passed
@github-actions
Copy link
Copy Markdown

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant