CI: namespace Foundry cache keys by mode (fix #203 cross-restore)#205
Conversation
#203 gave all sol workflows the same cache key + restore-keys prefix, but the saved archive depends on the *saver's* path set: a cache-only (determinism) job and a cache+out (build/test) job sharing a key cross-restore each other's archives — cache-only could restore a stale out/, and cache+out could restore an entry missing out/ (losing the speedup). Split into distinct namespaces: copy-artifacts -> foundry-co-*, the build/test workflows -> foundry-full-*. (build-pointers is left as-is; #204 retires it and it's now alone in the old namespace, so no collision.) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 45 minutes and 33 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Follow-up review of #203 caught a real bug CI didn't: all sol workflows shared one cache
key+restore-keysprefix (foundry-${{ runner.os }}-). GitHub's cache archive reflects the saver'spathset, and a matching-key restorer extracts that archive regardless of its ownpath— so the cache-only (determinism: copy-artifacts) and cache+out (build/test) groups cross-restore:out/(undermines the fresh-build intent — though forge build reconciles, so the assert stays valid)out/(silently loses the speedup)Split into distinct namespaces so the groups never share an entry:
rainix-copy-artifacts→foundry-co-${{ runner.os }}-…rainix-sol-test/-sol-static/-manual-sol-artifacts/test.yml→foundry-full-${{ runner.os }}-…rainix-build-pointersis intentionally left on the old prefix — #204 retires it, and it's now alone in that namespace (no collision).🤖 Generated with Claude Code