Skip to content

copy-artifacts: drop the Foundry build cache (no-op for a clean-build check)#206

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-05-27-copy-no-forge-cache
May 27, 2026
Merged

copy-artifacts: drop the Foundry build cache (no-op for a clean-build check)#206
thedavidmeister merged 1 commit into
mainfrom
2026-05-27-copy-no-forge-cache

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

copy-artifacts caches cache/ only (not out/) to keep its determinism assert honest. But forge needs out/ artifacts present to skip compilation — with out/ absent it recompiles to regenerate them, so cache/ alone yields no real speedup (measured: Build Solidity stayed ~105s). The actions/cache save/restore was therefore pure overhead.

Remove it — copy-artifacts is now a clean determinism check with no Foundry cache. The cache+out workflows (sol-test, sol-static, manual-sol-artifacts, rainix test.yml) keep the cache, where it genuinely skips recompilation.

🤖 Generated with Claude Code

… check)

Caching cache/ without out/ gives no speedup — forge recompiles to regenerate
the fresh out/ the determinism assert needs. So the actions/cache save/restore
was pure overhead. Remove it; the cache+out workflows (sol-test, sol-static,
manual-sol-artifacts, test.yml) keep the Foundry cache.
@thedavidmeister thedavidmeister self-assigned this May 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Warning

Review limit reached

@thedavidmeister, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 8 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a67fd3eb-b0c7-4cf5-b785-82745dc46954

📥 Commits

Reviewing files that changed from the base of the PR and between 8b2c684 and fadfc06.

📒 Files selected for processing (1)
  • .github/workflows/rainix-copy-artifacts.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-27-copy-no-forge-cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister merged commit 15b98f4 into main May 27, 2026
13 checks passed
@github-actions
Copy link
Copy Markdown

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant