copy-artifacts: drop the Foundry build cache (no-op for a clean-build check)#206
Conversation
… check) Caching cache/ without out/ gives no speedup — forge recompiles to regenerate the fresh out/ the determinism assert needs. So the actions/cache save/restore was pure overhead. Remove it; the cache+out workflows (sol-test, sol-static, manual-sol-artifacts, test.yml) keep the Foundry cache.
|
Warning Review limit reached
More reviews will be available in 35 minutes and 8 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
copy-artifacts caches
cache/only (notout/) to keep its determinism assert honest. But forge needsout/artifacts present to skip compilation — without/absent it recompiles to regenerate them, socache/alone yields no real speedup (measured:Build Soliditystayed ~105s). Theactions/cachesave/restore was therefore pure overhead.Remove it — copy-artifacts is now a clean determinism check with no Foundry cache. The
cache+outworkflows (sol-test, sol-static, manual-sol-artifacts, rainix test.yml) keep the cache, where it genuinely skips recompilation.🤖 Generated with Claude Code