`test_fixture` crate for main branch and v4 bindings by rouzwelt · Pull Request #335 · rainlanguage/rainlang

rouzwelt · 2025-06-06T21:14:01Z

Motivation

⚠️ Do NOT merge before #333

Related to rainlanguage/raindex#1878
This PR adds test_fixtures crate for the main branch (i9r v4), which is a local evm helper for testing, this now enables us to remove env crate.

Solution

add test_fixtures crate, this is a wrapped anvil structure with rain i9r contracts already deployed on it as well as helper functions to to easily interact with it for testing purpose.
remove env crate
update bindings to include i9r v4 contracts
update crates tests to use v4 contracts and local evm helper

Checks

By submitting this for review, I'm confirming I've done the following:

made this PR as small as possible
unit-tested any new functionality
linked any relevant issues or PRs
~~included screenshots (if this involves a front-end change)~~

coderabbitai · 2025-06-06T21:14:09Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

0xgleb · 2025-06-07T05:29:55Z

    pub decode_errors: bool,
+
+    // Accept inputs vector as array of uint256
+    #[arg(short, long, help = "The inputs vectore")]


typo

Suggested change

#[arg(short, long, help = "The inputs vectore")]

#[arg(short, long, help = "The inputs vector")]

0xgleb · 2025-06-07T05:33:35Z

Can we also update .env.example and CI to no longer use redundant env vars?

0xgleb · 2025-06-07T05:37:00Z

    /// * `deployer` - The address of the deployer.
    /// * `namespace` - The fully qualified namespace.
    /// * `context` - The context vector.
+    /// * `inputs` - The inputs vector.
+    /// * `state_overlay` - The state_overlay vector.
+    /// * `decode_errors` - Whether to decode errors from registry or not
    ///
    /// # Returns
    ///
    /// The typed return of the eval, plus Foundry's RawCallResult struct, including the trace.


Shouldn't these docs be on the type itself rather than on the method? Also, descriptions like "The state_overlay vector" don't add any info since it's already clear that the field name is state_overlay and that its type is a vector

0xgleb · 2025-06-07T05:47:26Z

+pub type LocalEvmFillers = JoinFill<
+    JoinFill<
+        alloy::providers::Identity,
+        JoinFill<
+            alloy::providers::fillers::GasFiller,
+            JoinFill<
+                alloy::providers::fillers::BlobGasFiller,
+                JoinFill<
+                    alloy::providers::fillers::NonceFiller,
+                    alloy::providers::fillers::ChainIdFiller,
+                >,
+            >,
+        >,
+    >,
+    WalletFiller<EthereumWallet>,
+>;


Do we need to list all of these out explicitly instead of referring to RecommendedFiller because BlobGasFiller doesn't include BlobGasFiller?

0xgleb

great stuff. thank you

rouzwelt self-assigned this Jun 6, 2025

rouzwelt changed the title ~~init~~ test_fixture crate for main branch and v4 bindings Jun 6, 2025

rouzwelt added the enhancement New feature or request label Jun 6, 2025

hardyjosh requested review from 0xgleb and hardyjosh June 6, 2025 21:30

0xgleb reviewed Jun 7, 2025

View reviewed changes

0xgleb mentioned this pull request Jun 7, 2025

Update alloy #333

Merged

4 tasks

rouzwelt requested a review from 0xgleb June 8, 2025 00:19

0xgleb approved these changes Jun 8, 2025

View reviewed changes

rouzwelt added 16 commits June 8, 2025 18:13

init

6a29dc9

Update TestERC20.sol

ffd2c54

Update TestERC20.sol

4359b73

fmt

f1fa512

Update eval.rs

955a67a

Update lib.rs

051d98a

fmt

f17bb0a

update

3de0ef9

update

84b63e0

Update eval.rs

564b363

Update eval.rs

575bf64

Update eval.rs

c63e9e7

Update eval.rs

c960930

Update eval.rs

e96364d

Update eval.rs

b63c295

Update trace.rs

d3141a6

0xgleb force-pushed the 2025-06-06-test-fixture-main-branch branch from d72807b to d3141a6 Compare June 8, 2025 14:13

hardyjosh approved these changes Jun 9, 2025

View reviewed changes

0xgleb merged commit a2e6a4e into upd/alloy Jun 9, 2025
11 checks passed

0xgleb deleted the 2025-06-06-test-fixture-main-branch branch June 9, 2025 07:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`test_fixture` crate for main branch and v4 bindings#335

`test_fixture` crate for main branch and v4 bindings#335
0xgleb merged 16 commits into
upd/alloyfrom
2025-06-06-test-fixture-main-branch

rouzwelt commented Jun 6, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 6, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

0xgleb Jun 7, 2025

Uh oh!

0xgleb Jun 7, 2025

Uh oh!

0xgleb Jun 7, 2025

Uh oh!

0xgleb Jun 7, 2025

Uh oh!

Uh oh!

0xgleb left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	#[arg(short, long, help = "The inputs vectore")]
	#[arg(short, long, help = "The inputs vector")]

Conversation

rouzwelt commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

⚠️ Do NOT merge before #333

Solution

Checks

Uh oh!

coderabbitai Bot commented Jun 6, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

0xgleb Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

0xgleb Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

0xgleb Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

0xgleb Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0xgleb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rouzwelt commented Jun 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)