[CRITICAL] Fix command injection in library#2
Closed
andreluis034 wants to merge 1 commit intoralt:masterfrom
andreluis034:master
Closed
[CRITICAL] Fix command injection in library#2andreluis034 wants to merge 1 commit intoralt:masterfrom andreluis034:master
andreluis034 wants to merge 1 commit intoralt:masterfrom
andreluis034:master
Conversation
Author
|
Please see the pr in 418sec#1 |
Owner
|
Why are you wasting everyone's time? |
Author
|
I just wanted to give the platform huntr.dev a try and accidentally opened a PR directly to your repository instead of the one forked by the platform. If you don't think it is worth fixing the command injection vulnerability in your library at least remove it from npm so that others do not use your vulnerable code accidentally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solution fixes the command injection in the library by utilizing
execFileinstead ofexecand by building the arguments in an array.