paper1: Fix erroneous arm length formula#4
Open
chordowl wants to merge 1 commit intoraphlinus:masterfrom
Open
Conversation
Replaces instances of `sin` in the formula for the arm length with `cos`. This must've been a mix-up while this was written up, as the code (<https://github.com/raphlinus/spline-research/blob/master/curves.js#L219>) uses `cos`. Now, paper and code match. (If one uses `sin`, the arm length seems to have the wrong sign, and even if one fixes that, the resulting curve behaves rather weirdly).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the two instances of
sinin the formula for the arm length withcos.There must've been a mix-up while this was written up, as the code uses
cos:spline-research/curves.js
Line 219 in 1a0fd3d
Now, paper and code match.
(If one were to use
sinas originally written, the arm length has the wrong sign most (if not all) the time. Even if one fixes that, the resulting curve behaves rather weirdly; I noticed this while trying to implement this curve for use with my pen plotter.)Best, and thanks for the write-up,
Lukas