Skip to content

Only load used attributes on product detail#1143

Closed
indykoning wants to merge 10 commits intomasterfrom
feature/only-eager-load-pdp-used-attributes
Closed

Only load used attributes on product detail#1143
indykoning wants to merge 10 commits intomasterfrom
feature/only-eager-load-pdp-used-attributes

Conversation

@indykoning
Copy link
Copy Markdown
Member

@indykoning indykoning commented Jan 12, 2026

Before:
image
after:
image

on a larger project:
Before & after
image

Still, is it worth the confusion when attributes do not work since you haven't added it to the config?

@indykoning indykoning requested a review from royduin as a code owner January 12, 2026 12:44
Comment thread src/Http/Controllers/ProductController.php Outdated
Comment thread src/Http/Controllers/ProductController.php Outdated
@indykoning
Copy link
Copy Markdown
Member Author

is it worth the confusion when attributes do not work since you haven't added it to the config?
Only on big projects it has impact on the amount of options and attributes loaded
image
1k of ~20k models, there is no change in the amount of queries.
nor is there a large difference in time or amount of queries executed.

@royduin
Copy link
Copy Markdown
Member

royduin commented Feb 11, 2026

This isn't improving as much as we like, so closing.

@royduin royduin closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants