Get non-flat table attributes using relations instead of join#906
Draft
indykoning wants to merge 11 commits intomasterfrom
Draft
Get non-flat table attributes using relations instead of join#906indykoning wants to merge 11 commits intomasterfrom
indykoning wants to merge 11 commits intomasterfrom
Conversation
…idez/core into feature/pdp-relation-instead-of-join
Jade-GG
force-pushed
the
feature/pdp-relation-instead-of-join
branch
from
dc6ba2f to
a285298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is inspired from https://github.com/rapidez/core/tree/replace-flat-with-eav and can be a start of the migration.
This PR will exclude non-flat attributes from being selected with selectForProductPage. preventing the joins from taking place.
Any attributes that are used and unavailable on the PDP will be pulled from relationships instead of the joins.