Migrate RMM usage to CCCL memory resource design#1990
Draft
bdice wants to merge 1 commit intorapidsai:mainfrom
Draft
Migrate RMM usage to CCCL memory resource design#1990bdice wants to merge 1 commit intorapidsai:mainfrom
bdice wants to merge 1 commit intorapidsai:mainfrom
Conversation
Adapt cuVS to RMM breaking changes: removal of device_memory_resource base class, de-templated resource/adaptor types, new per-device resource ref APIs, and CCCL resource concept requirements. Key changes: - get_workspace_resource() -> get_workspace_resource_ref() (44 sites) - get_large_workspace_resource() -> get_large_workspace_resource_ref() (21 sites) - get_current_device_resource() -> get_current_device_resource_ref() - device_memory_resource* params -> device_async_resource_ref - Remove &resource pointer patterns (resources are now value types) - Migrate cuda_huge_page_resource to CCCL concept - De-template pool_memory_resource, failure_callback_resource_adaptor - Rewrite C API pool resource management without owning_wrapper - Remove deleted rmm/mr/device_memory_resource.hpp includes
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device_async_resource_refinstead ofdevice_memory_resource*, value semantics)get_workspace_resource()/get_large_workspace_resource()with_ref()variants across 65 call sitescuda_huge_page_resourceto satisfy CCCLresourceconcept directlyowning_wrapper/dynamic_castpatterns in C API and benchmarksChanges
device_memory_resource*params →device_async_resource_ref(ivf_common, ivf_pq, naive_knn)get_current_device_resource()→get_current_device_resource_ref()set_current_device_resource()→set_current_device_resource_ref()pool_memory_resource,failure_callback_resource_adaptorin bench utils&resourcepointer patterns (resources are now copyable value types)mrarg fromselect_kcalls (previously compiled due to implicit pointer→bool conversion)owning_wrapperDepends on rapidsai/raft#2996.