Skip to content

exit with error if creating python environment fails #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trxcllnt wants to merge 8 commits into
base: main
Choose a base branch
from
Open

exit with error if creating python environment fails #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f0130f
exit with error if creating python environment fails
trxcllnt Mar 6, 2026
051d655
bump feature version
trxcllnt Mar 6, 2026
2dde708
print exit code
trxcllnt Mar 6, 2026
47e350c
Merge branch 'main' of github.com:rapidsai/devcontainers into fix/rap…
trxcllnt Mar 6, 2026
6f589af
bump feature version
trxcllnt Mar 6, 2026
3ae6d00
print exit code
trxcllnt Mar 6, 2026
86b87c8
set -e in rapids-post-start-command
trxcllnt Mar 6, 2026
d00026b
use devcontainers key for rapidsmpf dependencies
trxcllnt Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions features/src/rapids-build-utils/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"name": "NVIDIA RAPIDS devcontainer build utilities",
"id": "rapids-build-utils",
"version": "26.4.4",
"version": "26.4.5",
"description": "A feature to install the RAPIDS devcontainer build utilities",
"containerEnv": {
"BASH_ENV": "/etc/bash.bash_env"
},
"postStartCommand": [
"/bin/bash",
"-li",
"-lic",
"+o",
"history",
"rapids-post-start-command"
"rapids-post-start-command || true"
]
}
11 changes: 9 additions & 2 deletions features/src/rapids-build-utils/opt/rapids-build-utils/bin/post-start-command.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
#!/usr/bin/env bash

if ! test -n "${SKIP_RAPIDS_BUILD_UTILS_POST_START_COMMAND:+x}"; then
_rapids_post_start_command() {
local -;
set -euo pipefail;

rapids-generate-scripts;
rapids-update-build-dir-links -j &
rapids-make-vscode-workspace --update &
rapids-merge-compile-commands-json > ~/compile_commands.json &
if test -n "${PYTHON_PACKAGE_MANAGER:+x}"; then
rapids-make-"${PYTHON_PACKAGE_MANAGER}"-env "$@" || true;
rapids-make-"${PYTHON_PACKAGE_MANAGER}"-env "$@";
fi
wait
}

if ! test -n "${SKIP_RAPIDS_BUILD_UTILS_POST_START_COMMAND:+x}"; then
_rapids_post_start_command "$@" <&0;
fi
2 changes: 2 additions & 0 deletions features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ repos:
- name: rapidsmpf
path: rapidsmpf
git: {<<: *git_defaults, repo: rapidsmpf}
dependency_keys:
- devcontainers
cpp:
- name: rapidsmpf
sub_dir: cpp
Expand Down
Loading