Skip to content

Use mamba to create devcontainer conda envs#704

Merged
trxcllnt merged 13 commits into
rapidsai:mainfrom
bdice:fix/use-mamba-env-create
May 20, 2026
Merged

Use mamba to create devcontainer conda envs#704
trxcllnt merged 13 commits into
rapidsai:mainfrom
bdice:fix/use-mamba-env-create

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented May 19, 2026

Description

Switch rapids-make-conda-env from conda env create --solver=libmamba to mamba env create.

This keeps environment creation on mamba directly instead of invoking conda's env frontend with the libmamba solver.

Error outputs from mamba tend to be clearer, and it doesn't spam logs with a spinner like - / | \ - / | \...

@bdice bdice requested a review from a team as a code owner May 19, 2026 17:01
@bdice bdice requested review from msarahan and removed request for a team May 19, 2026 17:01
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like as of #249 we are always making conda envs from scratch rather than updating. That being the case, can we narrow what's done conditionally here and merge more of the code paths for creating/updating? The comments are also a bit out of date relative to the current state of how it's working now.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we always delete and recreate the env instead of updating it, because conda doesn't clean up after itself.

Copy link
Copy Markdown
Collaborator

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also bump the versions in the respective features' devcontainer-feature.json file?

@trxcllnt
Copy link
Copy Markdown
Collaborator

Does mamba not respect the CONDA_ALWAYS_YES=true envvar? Or does it need to be MAMBA_ALWAYS_YES=true?

@trxcllnt
Copy link
Copy Markdown
Collaborator

Ignoring CONDA_PKGS_DIRS may be a mamba bug?

@trxcllnt trxcllnt force-pushed the fix/use-mamba-env-create branch from cb26471 to 872b0b9 Compare May 20, 2026 19:01
@trxcllnt
Copy link
Copy Markdown
Collaborator

@trxcllnt trxcllnt merged commit aea286b into rapidsai:main May 20, 2026
29 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants