Skip to content

update pip devcontainers' base image tags#96

Open
trxcllnt wants to merge 1 commit intorapidsai:mainfrom
trxcllnt:fea/update-pip-devcontainer-base
Open

update pip devcontainers' base image tags#96
trxcllnt wants to merge 1 commit intorapidsai:mainfrom
trxcllnt:fea/update-pip-devcontainer-base

Conversation

@trxcllnt
Copy link
Copy Markdown
Contributor

@trxcllnt trxcllnt commented Apr 4, 2026

These new pip devcontainers have GCC v14 to support building cuOpt. Unfortunately OpenMPI v5.0.7 doesn't compile with GCC v14, so I also updated to OpenMPI v5.0.10.

@trxcllnt trxcllnt requested a review from a team as a code owner April 4, 2026 02:50
@trxcllnt trxcllnt requested a review from bdice April 4, 2026 02:50
@trxcllnt trxcllnt added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 4, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 369958cd-8595-4b06-8caf-05f195d2e848

📥 Commits

Reviewing files that changed from the base of the PR and between 4c026b9 and 29cad80.

📒 Files selected for processing (2)
  • .devcontainer/cuda12.9-pip/devcontainer.json
  • .devcontainer/cuda13.1-pip/devcontainer.json

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated development container base images to use OpenMPI 5.0.10 across both CUDA 12.9 and CUDA 13.1 devcontainer configurations. These infrastructure updates enhance underlying dependency versions and improve stability for developers working with containerized development environments. The updates ensure better compatibility and enhanced performance for local development setups.

Walkthrough

Updates Docker base image versions in two devcontainer configuration files from openmpi5.0.7 to openmpi5.0.10 for CUDA 12.9 and 13.1 environments. These are configuration-only changes to the underlying container images used for development.

Changes

Cohort / File(s) Summary
Devcontainer Base Image Updates
.devcontainer/cuda12.9-pip/devcontainer.json, .devcontainer/cuda13.1-pip/devcontainer.json
Updated BASE Docker build argument to upgrade OpenMPI from version 5.0.7 to 5.0.10 in the underlying container images for both CUDA 12.9 and 13.1 configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

improvement, non-breaking

Suggested reviewers

  • jameslamb
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating base image tags for pip devcontainers. It accurately reflects the primary objective of the changeset.
Description check ✅ Passed The description directly relates to the changeset, explaining the motivation (GCC v14 support for cuOpt) and the implementation details (OpenMPI version update). It provides meaningful context for the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant