Avoid defining awaitable in PyActor.__init__#941
Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom Apr 6, 2026
Merged
Avoid defining awaitable in PyActor.__init__#941rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
PyActor.__init__#941rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
Conversation
| assert_eq(tbl.table_view(), expect) | ||
|
|
||
|
|
||
| @pytest.mark.filterwarnings("error") |
Contributor
There was a problem hiding this comment.
This is fine, but I opened #942 to do it by default.
PyActor.__init__
TomAugspurger
approved these changes
Apr 6, 2026
Contributor
TomAugspurger
left a comment
There was a problem hiding this comment.
I think this looks good, but maybe @madsbk can take a look as well when he has a chance.
Co-authored-by: Mads R. B. Kristensen <madsbk@gmail.com>
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running the Polars test suite with cudf_polars + rapidsmpf (with warnings as errors), I noticed this
RuntimeErrorClaude pointed me to
PyActorcreating an awaitable in__init__that has a possibility of never being awaited and a solution to create this awaitable within__await__instead.I was able to reproduce a similar failure in
test_unawaited_actor_closed_coroutines_no_warningwithout this fix that raises