Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis pull request upgrades React from version 18 to 19 across the admin application and SDK, updates related type definitions and third-party dependencies, adds Vite module deduplication configuration, and adjusts SDK peer dependencies to support both React 18 and 19 versions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request Test Coverage Report for Build 23534998163Details
💛 - Coveralls |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7a4e7a9a-fca4-4cde-82fe-df489d556e4d
⛔ Files ignored due to path filters (2)
web/apps/admin/pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlweb/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
web/apps/admin/package.jsonweb/apps/admin/vite.config.tsweb/sdk/package.jsonweb/sdk/react/components/onboarding/updates.tsx
| "@types/react": "^19.0.0", | ||
| "@types/react-dom": "^19.0.0", |
There was a problem hiding this comment.
Potential type mismatch for React 18 consumers.
The peerDependencies now support both React 18 and 19 (^18.2.0 || ^19.0.0), which is good for flexibility. However, the devDependencies specify @types/react: ^19.0.0 and @types/react-dom: ^19.0.0.
This means the SDK's emitted type definitions (.d.ts files) will be built against React 19 types. If a consumer uses React 18, they may encounter type incompatibilities since React 19 types have breaking changes (e.g., ReactNode type changes, useRef requiring an argument, ref callback cleanup functions).
Consider either:
- Keeping types at React 18 for broader compatibility, or
- Documenting that React 19 types are expected for consumers
Also applies to: 124-125
Summary
Upgrade Admin to React 19.
Changes
Technical Details
Test Plan