Skip to content

feat: upgrade to react 19#1474

Open
paanSinghCoder wants to merge 2 commits intomainfrom
feat/admin-react-19
Open

feat: upgrade to react 19#1474
paanSinghCoder wants to merge 2 commits intomainfrom
feat/admin-react-19

Conversation

@paanSinghCoder
Copy link
Contributor

Summary

Upgrade Admin to React 19.

Changes

Technical Details

Test Plan

  • Manual testing completed
  • Build and type checking passes

@paanSinghCoder paanSinghCoder self-assigned this Mar 24, 2026
@vercel
Copy link

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Mar 25, 2026 9:53am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Chores
    • Upgraded core dependencies to support the latest version while maintaining backward compatibility with previous versions.
    • Updated associated type definitions and component library versions.
    • Enhanced module resolution configuration for improved runtime stability.

Walkthrough

This pull request upgrades React from version 18 to 19 across the admin application and SDK, updates related type definitions and third-party dependencies, adds Vite module deduplication configuration, and adjusts SDK peer dependencies to support both React 18 and 19 versions.

Changes

Cohort / File(s) Summary
Admin App React Upgrade
web/apps/admin/package.json, web/apps/admin/vite.config.ts
Upgraded React and React-DOM to v19, updated associated type definitions, bumped Radix UI react-form; added Vite resolve.dedupe configuration for react and react-dom to ensure module singleton behavior.
SDK Package Modernization
web/sdk/package.json
Bumped Radix UI react-form to v0.1.8, updated React type definitions to v19, upgraded TanStack React Router to v1.168.3, and adjusted peer dependencies for React and React-DOM to accept both v18 and v19 ranges.
Import Path Correction
web/sdk/react/components/onboarding/updates.tsx
Fixed ReactNode import source from @tanstack/react-router to react.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

coveralls commented Mar 24, 2026

Pull Request Test Coverage Report for Build 23534998163

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.238%

Totals Coverage Status
Change from base Build 23531460663: 0.0%
Covered Lines: 14699
Relevant Lines: 35644

💛 - Coveralls

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7a4e7a9a-fca4-4cde-82fe-df489d556e4d

📥 Commits

Reviewing files that changed from the base of the PR and between 9dba632 and edd07e9.

⛔ Files ignored due to path filters (2)
  • web/apps/admin/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • web/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • web/apps/admin/package.json
  • web/apps/admin/vite.config.ts
  • web/sdk/package.json
  • web/sdk/react/components/onboarding/updates.tsx

Comment on lines +79 to +80
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Potential type mismatch for React 18 consumers.

The peerDependencies now support both React 18 and 19 (^18.2.0 || ^19.0.0), which is good for flexibility. However, the devDependencies specify @types/react: ^19.0.0 and @types/react-dom: ^19.0.0.

This means the SDK's emitted type definitions (.d.ts files) will be built against React 19 types. If a consumer uses React 18, they may encounter type incompatibilities since React 19 types have breaking changes (e.g., ReactNode type changes, useRef requiring an argument, ref callback cleanup functions).

Consider either:

  1. Keeping types at React 18 for broader compatibility, or
  2. Documenting that React 19 types are expected for consumers

Also applies to: 124-125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants