feat (rql): add ilike and notilike support#83
Conversation
📝 WalkthroughWalkthroughExtended string filter operator validation in the RQL parser to support case-insensitive variants Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@rql/parser.go`:
- Line 12: Add end-to-end tests for the new case-insensitive string operators by
adding test cases for "ilike" and "notilike" in parser_test.go (exercise the
parser/validation path the same way existing "like"/"notlike" tests do),
ensuring they parse and validate successfully against validStringOperations;
also update rql/README.md to list "ilike" and "notilike" as supported string
operators and note that correct SQL generation depends on the downstream SQL
builder (e.g., confirm GoQU or your SQL layer supports ILIKE/case-insensitive
comparisons).
Add
ilikeandnotilikeoperators to the validStringOperations list in the RQL parser. This enables case-insensitive pattern matching support for string fields, complementing the existing like and notlike operators.Related PR - raystack/frontier#1472
Summary by CodeRabbit
ilikeandnotilikealongside existing filter options, providing more flexible search capabilities.