Skip to content

feat (rql): add ilike and notilike support#83

Open
paanSinghCoder wants to merge 1 commit intomainfrom
feat/add-ilike-notilike-support
Open

feat (rql): add ilike and notilike support#83
paanSinghCoder wants to merge 1 commit intomainfrom
feat/add-ilike-notilike-support

Conversation

@paanSinghCoder
Copy link

@paanSinghCoder paanSinghCoder commented Mar 25, 2026

Add ilike and notilike operators to the validStringOperations list in the RQL parser. This enables case-insensitive pattern matching support for string fields, complementing the existing like and notlike operators.

Related PR - raystack/frontier#1472

Summary by CodeRabbit

  • New Features
    • Extended query string filtering to support additional case-insensitive operators ilike and notilike alongside existing filter options, providing more flexible search capabilities.

@paanSinghCoder paanSinghCoder self-assigned this Mar 25, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026

📝 Walkthrough

Walkthrough

Extended string filter operator validation in the RQL parser to support case-insensitive variants ilike and notilike. The change expands the validStringOperations list while maintaining existing validation logic and control flow.

Changes

Cohort / File(s) Summary
String Operator Validation
rql/parser.go
Added ilike and notilike case-insensitive operator variants to the validStringOperations validation set alongside existing like and notlike operators.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A parser's delight, both subtle and bright,
Case-insensitive variants now in sight!
Like becomes ilike, a flexible friend,
Where queries bend, there's no end—
More operators to parse with glee! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding ilike and notilike operators to support case-insensitive string filtering in the RQL parser.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-ilike-notilike-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@rql/parser.go`:
- Line 12: Add end-to-end tests for the new case-insensitive string operators by
adding test cases for "ilike" and "notilike" in parser_test.go (exercise the
parser/validation path the same way existing "like"/"notlike" tests do),
ensuring they parse and validate successfully against validStringOperations;
also update rql/README.md to list "ilike" and "notilike" as supported string
operators and note that correct SQL generation depends on the downstream SQL
builder (e.g., confirm GoQU or your SQL layer supports ILIKE/case-insensitive
comparisons).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 675c3b5b-0387-4442-bb92-b7c012bb09ab

📥 Commits

Reviewing files that changed from the base of the PR and between abdfc17 and 3bd411e.

📒 Files selected for processing (1)
  • rql/parser.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants