Open
Conversation
|
Thank you for submitting a pull request to this project! Once all When the |
ryan-rs
force-pushed
the
ryan-rs/ASC-978/update_rpc-zigzag
branch
from
0eb779b to
71076fc
Compare
zreichert
previously approved these changes
Feb 25, 2019
johnduarte
previously approved these changes
Feb 25, 2019
Contributor
|
@ryan-rs can you articulate why this PR should not be merged? |
phongdly
previously approved these changes
Feb 25, 2019
ryan-rs
dismissed stale reviews from phongdly, johnduarte, and zreichert
via
b137093
ryan-rs
force-pushed
the
ryan-rs/ASC-978/update_rpc-zigzag
branch
from
b137093 to
a947894
Compare
Update the script to pin to the 1.0 series for "rpc-zigzag". Also, added a variable for the "rpc-zigzag" PyPI package at the top so it can be easily updated in the future without hunting around in the script. The ZigZag config file is contained as a heredoc within the script which is written out to disk at runtime.
This pins the openstack-ansible-tests to a known working SHA. (cherry picked from commit 284cf7a)
ryan-rs
force-pushed
the
ryan-rs/ASC-978/update_rpc-zigzag
branch
from
a947894 to
b6e8e8e
Compare
Contributor
Author
|
recheck_bionic_no_artifacts_swift_deploy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the script to pin to the 1.0 series for "rpc-zigzag". Also, add a
variable for the "rpc-zigzag" PyPI package at the top so it can be easily
updated in the future without hunting around in the script.
Issue: ASC-978