Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a footer to the frontend application and introduces two new GitHub Actions CI workflow configurations for demonstration purposes. The PR includes updates to documentation describing "Lab 5 - CI Optimization".
- Added a copyright footer to the frontend HTML with inline styling
- Created two CI workflow files: one unoptimized (ci2.yml) and one optimized (ci-optimized.yml) to demonstrate performance improvements
- Updated README files with new Lab 5 section header
Reviewed changes
Copilot reviewed 5 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lab5/sample-ci/frontend/index.html | Added footer with copyright notice and CI/CD Demo branding |
| lab5/sample-ci/README.md | Added "Lab 5 - CI Optimization" section header |
| README.md | Added "Lab 5 - CI Optimization" section header |
| .github/workflows/ci2.yml | New unoptimized CI workflow demonstrating sequential frontend jobs without caching |
| .github/workflows/ci-optimized.yml | New optimized CI workflow with caching and parallelized backend/frontend jobs |
| .DS_Store, lab5/.DS_Store, lab5/sample-ci/.DS_Store, lab5/sample-ci/backend/.DS_Store, .github/.DS_Store | macOS system files that should not be committed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </div> | ||
| </div> | ||
|
|
||
| <!-- Na końcu <body>, przed </body> --> |
There was a problem hiding this comment.
The HTML comment is in Polish while the rest of the codebase appears to use English for comments. For consistency, consider using English: "At the end of <body>, before </body>".
| <!-- Na końcu <body>, przed </body> --> | |
| <!-- At the end of <body>, before </body> --> |
.github/workflows/ci2.yml
Outdated
| - name: Install dependencies | ||
| run: | | ||
| cd lab5/sample-ci/frontend | ||
| npm install | ||
|
|
||
| frontend-test: | ||
| name: Frontend - Test | ||
| runs-on: ubuntu-latest | ||
| needs: frontend-install | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| cd lab5/sample-ci/frontend | ||
| npm install | ||
|
|
||
| - name: Run tests | ||
| run: | | ||
| cd lab5/sample-ci/frontend | ||
| npm test | ||
|
|
||
| frontend-build: | ||
| name: Frontend - Build | ||
| runs-on: ubuntu-latest | ||
| needs: frontend-test | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| cd lab5/sample-ci/frontend | ||
| npm install |
There was a problem hiding this comment.
Dependencies are installed three times (lines 19-22, 36-39, 58-61) across separate jobs without caching or artifact reuse. This is inefficient and increases CI runtime. Consider using dependency caching (actions/cache) or sharing node_modules as an artifact between jobs.
1 participant
test