Open
Conversation
We can use a rdpdr_send_client_device_list_announce/ rdpdr_send_client_device_list_remove pair to implement dynamic device insertion/removal in the future.
Member
|
So if I understand it right there's no code that actually uses this new |
Member
Author
|
Yes. I'm proposing to add it only because:
It's perfectly OK if you prefer not to merge it ATM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this function along with rdpdr_send_client_device_list_announce()
it's rather trivial to add support for dynamic devices in the future.
For example, you can detect smartcard reader insertion and pass it to
the TS (depending on your settings, of course). After removal you can
ask TS to remove it too.
Or you can implement dynamic disks support in such way that each new disk
is passed individually to the TS after insertion thus no need to supply
the disk path while starting rdesktop.