Conversation
kelleyloder
commented
Apr 30, 2026
kelleyloder
commented
- cherry-picked changes from "Fix flaky tests" PR (but to develop branch)
- fixed merge conflicts
- removed tenantId references (since not in develop branch)
- modified table name changes
- changed one unit test to correctly look for 400 instead of 404
…ential execution - Add SkipIfMockDatabase() helper to skip tests that require real Cassandra - Use unique IDs (timestamps) to prevent test collisions - Add time.Sleep for Cassandra eventual consistency - Update Makefile to run tests sequentially (-p 1) to avoid DB race conditions - Tests now pass reliably in both mock and real DB modes
- Fix TestDeleteLogRepoSettingsbyId_Success: use uniqueID instead of hardcoded 'delete-me' - Remove unnecessary DeleteAllEntities() from pure validation tests - Add delay after create before delete for Cassandra consistency
Fix test failures for real DB mode
pt-nguyen
previously approved these changes
May 7, 2026
pt-nguyen
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.