Skip to content

Fix test failures for real DB mode #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kelleyloder merged 1 commit into from
Apr 30, 2026
Merged

Fix test failures for real DB mode #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 13 additions & 24 deletions adminapi/dcm/logrepo_settings_service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ func TestGetLogRepoSettingsAll_WithRepositories(t *testing.T) {

// TestLogRepoSettingsValidate_NilInput tests validation with nil repository
func TestLogRepoSettingsValidate_NilInput(t *testing.T) {
DeleteAllEntities()
defer DeleteAllEntities()

// No DB cleanup needed - pure validation test
respEntity := LogRepoSettingsValidate(nil)

assert.Equal(t, http.StatusBadRequest, respEntity.Status)
Expand All @@ -116,9 +114,7 @@ func TestLogRepoSettingsValidate_NilInput(t *testing.T) {

// TestLogRepoSettingsValidate_EmptyApplicationType tests validation with empty ApplicationType
func TestLogRepoSettingsValidate_EmptyApplicationType(t *testing.T) {
DeleteAllEntities()
defer DeleteAllEntities()

// No DB cleanup needed - pure validation test
repo := &logupload.UploadRepository{
ID: "test-id",
Name: "Test Repo",
Expand All @@ -136,9 +132,7 @@ func TestLogRepoSettingsValidate_EmptyApplicationType(t *testing.T) {

// TestLogRepoSettingsValidate_EmptyName tests validation with empty name
func TestLogRepoSettingsValidate_EmptyName(t *testing.T) {
DeleteAllEntities()
defer DeleteAllEntities()

// No DB cleanup needed - pure validation test
repo := &logupload.UploadRepository{
ID: "test-id",
Name: "", // Empty
Expand All @@ -156,9 +150,7 @@ func TestLogRepoSettingsValidate_EmptyName(t *testing.T) {

// TestLogRepoSettingsValidate_EmptyURL tests validation with empty URL
func TestLogRepoSettingsValidate_EmptyURL(t *testing.T) {
DeleteAllEntities()
defer DeleteAllEntities()

// No DB cleanup needed - pure validation test
repo := &logupload.UploadRepository{
ID: "test-id",
Name: "Test Repo",
Expand All @@ -176,9 +168,7 @@ func TestLogRepoSettingsValidate_EmptyURL(t *testing.T) {

// TestLogRepoSettingsValidate_InvalidURL tests validation with invalid URL
func TestLogRepoSettingsValidate_InvalidURL(t *testing.T) {
DeleteAllEntities()
defer DeleteAllEntities()

// No DB cleanup needed - pure validation test
repo := &logupload.UploadRepository{
ID: "test-id",
Name: "Test Repo",
Expand All @@ -195,9 +185,7 @@ func TestLogRepoSettingsValidate_InvalidURL(t *testing.T) {

// TestLogRepoSettingsValidate_EmptyProtocol tests validation with empty protocol
func TestLogRepoSettingsValidate_EmptyProtocol(t *testing.T) {
DeleteAllEntities()
defer DeleteAllEntities()

// No DB cleanup needed - pure validation test
repo := &logupload.UploadRepository{
ID: "test-id",
Name: "Test Repo",
Expand All @@ -215,9 +203,7 @@ func TestLogRepoSettingsValidate_EmptyProtocol(t *testing.T) {

// TestLogRepoSettingsValidate_InvalidProtocol tests validation with invalid protocol
func TestLogRepoSettingsValidate_InvalidProtocol(t *testing.T) {
DeleteAllEntities()
defer DeleteAllEntities()

// No DB cleanup needed - pure validation test
repo := &logupload.UploadRepository{
ID: "test-id",
Name: "Test Repo",
Expand Down Expand Up @@ -616,8 +602,11 @@ func TestDeleteLogRepoSettingsbyId_Success(t *testing.T) {
}
CreateLogRepoSettings(repo, "stb")

// Delete it
respEntity := DeleteLogRepoSettingsbyId("delete-me", "stb")
// Allow cache to refresh after create
time.Sleep(100 * time.Millisecond)

// Delete it - use the same uniqueID
respEntity := DeleteLogRepoSettingsbyId(uniqueID, "stb")
Comment on lines +605 to +609

assert.Equal(t, http.StatusNoContent, respEntity.Status)
assert.Assert(t, respEntity.Error == nil)
Expand All @@ -626,7 +615,7 @@ func TestDeleteLogRepoSettingsbyId_Success(t *testing.T) {
time.Sleep(100 * time.Millisecond)

// Verify deletion
deleted := GetLogRepoSettings("delete-me")
deleted := GetLogRepoSettings(uniqueID)
assert.Assert(t, deleted == nil)
}

Expand Down
Loading