-
Notifications
You must be signed in to change notification settings - Fork 608
fix: new NativeEventEmitter() was called with a non-null argument console warning #460
Conversation
|
Is this a breaking change or just a warning? I'm trying to figure out why voice is not working. Edit for reference: not a breaking change that I could see, voice still worked despite the warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone with write permissions approve this? (eg. @carlmagumpara I think, among several others)
Adding these methods resolves the related RN warnings. This is not a breaking change since it does not implement any functional code changes or modify dependencies.
|
NOTE: Anyone can review this PR, but in order for it to be merged automatically, we need the author or a contributor to review it. |
|
Please merge this changes. |
|
Can someone merge this? Or is this not maintained anymore? |
LuizHGodoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works for me as well.
|
Is anyone maintaining this module? Will this change ever get merged? |
|
This project has been deprecated and archived. Please migrate to expo-speech-recognition. Thank you for your contribution! ❤️ |
Add
addListenerandremoveListenersmethod to stop console warning about:Issue #455
reference