-
Notifications
You must be signed in to change notification settings - Fork 4
Support build for sentry #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
97f7597
add logic to support sentry
bozaigao 065ef86
udpate
bozaigao ff5713c
change reference path
bozaigao 2389c6d
support git commits and version info
bozaigao c22dc03
udate
bozaigao 8803e7f
add try catch for require.resolve
bozaigao 4e9d0f9
update upload sourcemap workflow
bozaigao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { plugins } from './plugin-config'; | ||
|
|
||
| interface BundleParams { | ||
| sentry: boolean; | ||
| minify: boolean; | ||
| sourcemap: boolean; | ||
| [key: string]: any; | ||
| } | ||
|
|
||
| export async function checkPlugins(): Promise<BundleParams> { | ||
| const params: BundleParams = { | ||
| sentry: true, | ||
| minify: true, | ||
| sourcemap: false, | ||
| }; | ||
|
|
||
| for (const plugin of plugins) { | ||
| try { | ||
| const isEnabled = await plugin.detect(); | ||
| if (isEnabled && plugin.bundleParams) { | ||
| Object.assign(params, plugin.bundleParams); | ||
| console.log(`检测到 ${plugin.name} 插件,应用相应打包配置`); | ||
| } | ||
| } catch (err) { | ||
| console.warn(`检测 ${plugin.name} 插件时出错:`, err); | ||
| } | ||
| } | ||
|
|
||
| return params; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import fs from 'fs-extra'; | ||
|
|
||
| interface PluginConfig { | ||
| name: string; | ||
| bundleParams?: { | ||
| minify?: boolean; | ||
| [key: string]: any; | ||
| }; | ||
| detect: () => Promise<boolean>; | ||
| } | ||
|
|
||
| export const plugins: PluginConfig[] = [ | ||
| { | ||
| name: 'sentry', | ||
| bundleParams: { | ||
| sentry: true, | ||
| minify: false, | ||
| sourcemap: true, | ||
| }, | ||
| detect: async () => { | ||
| try { | ||
| await fs.access('ios/sentry.properties'); | ||
| return true; | ||
| } catch { | ||
| try { | ||
| await fs.access('android/sentry.properties'); | ||
| return true; | ||
| } catch { | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ]; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不能这样直接写路径,要考虑monorepo和其他非典型情况,参考其他取路径的情况,用require.resolve去搜索路径
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.