Skip to content

Drop ruby 2.7 and switch to ruby 3.2 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnewbigin wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Drop ruby 2.7 and switch to ruby 3.2 #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1cf0c4
Drop explicit ruby 2.7 support
jnewbigin Jun 13, 2023
d65a4ce
Add ruby 3.2 wrapper
jnewbigin Jun 13, 2023
6fae049
Update docker image versions
jnewbigin Jun 13, 2023
b2fe9e2
Drop ruby 2.7 and test on ruby 3.2
jnewbigin Jun 13, 2023
6eff507
Changes for 1.9
jnewbigin Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['2.7', '3.0', '3.1', '3.2']
ruby-version: ['3.0', '3.1', '3.2']

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 6 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# CHANGES

## 1.9.0 (2023-06-13)

* Feature: Switch to ruby 3.2
* Feature: Remove support for ruby 2.7 (end of life)
* Dev: Upgrade dev setup and base docker image to ruby 3.2

## 1.8.0 (2022-08-23)

* Feature: Add support for ruby 3.1
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:3.1-alpine@sha256:499a310e8fab835ad47ab6251302aba1fd6ba91ebdfa22d621f495a5d0ded170 as build
FROM ruby:3.2-alpine@sha256:1df6125b0f90e087123698e1b2df1c6a544a40033a5a14bfa3ef7067863d3474 as build

WORKDIR /app
COPY bin /app/bin
Expand All @@ -10,7 +10,7 @@ COPY LICENSE.md /app/
COPY stackup.gemspec /app/
RUN gem build stackup.gemspec

FROM ruby:3.1-alpine@sha256:499a310e8fab835ad47ab6251302aba1fd6ba91ebdfa22d621f495a5d0ded170
FROM ruby:3.2-alpine@sha256:1df6125b0f90e087123698e1b2df1c6a544a40033a5a14bfa3ef7067863d3474

MAINTAINER https://github.com/realestate-com-au/stackup

Expand Down
2 changes: 1 addition & 1 deletion auto/lint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ cd $(dirname $0)/..

echo "+++ Running linter"
# We lint on the lowest supported ruby version
./auto/ruby-2.7 rubocop
./auto/ruby-3.0 rubocop
6 changes: 0 additions & 6 deletions auto/ruby-2.7
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion auto/ruby-3.0
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
set -eu -o pipefail
cd $(dirname $0)/..

RUBY_IMAGE="ruby:3.0@sha256:dfb439f51e6ba58810fed23e4c4582f3e3c24e6a972ec505de27217f5036c567" exec auto/ruby "${@}"
RUBY_IMAGE="ruby:3.0@sha256:df252539300fd851c4c3f26d1d849686dd5c1bb46cf403e1d6a87d3d304a80f4" exec auto/ruby "${@}"
2 changes: 1 addition & 1 deletion auto/ruby-3.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
set -eu -o pipefail
cd $(dirname $0)/..

RUBY_IMAGE="ruby:3.1@sha256:ffdb4e42cf4663e10c32d3ea91312b61df931b41439c16f7b88a7f6e70a65b6d" exec auto/ruby "${@}"
RUBY_IMAGE="ruby:3.1@sha256:5bb1b8ce2f236cc264ae2f2664ec226603655b9129bd9442841a91fc6bb32313" exec auto/ruby "${@}"
6 changes: 6 additions & 0 deletions auto/ruby-3.2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env bash

set -eu -o pipefail
cd $(dirname $0)/..

RUBY_IMAGE="ruby:3.2@sha256:5efd846bccfafcabada226808406275e92269889467d571e897afc104e8c76c9" exec auto/ruby "${@}"
6 changes: 3 additions & 3 deletions auto/test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
set -eu -o pipefail
cd $(dirname $0)/..

echo "+++ Running specs for ruby 3.2"
./auto/ruby-3.2 rspec

echo "+++ Running specs for ruby 3.1"
./auto/ruby-3.1 rspec

echo "+++ Running specs for ruby 3.0"
./auto/ruby-3.0 rspec

echo "+++ Running specs for ruby 2.7"
./auto/ruby-2.7 rspec
2 changes: 1 addition & 1 deletion lib/stackup/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module Stackup

VERSION = "1.8.0"
VERSION = "1.9.0"

end